coverity fixes #1879
Closed
coverity fixes #1879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the temp InternalKeyComparator will be destructed after evaluating the expression of `RangeDelAggregator range_del_agg(...)`, and RangeDelAggregator is keeping a const reference of it. this put RangeDelAggregator in danger when dereferencing icmp_ to access the aleady destroyed InternalKeyComparator temporary variable. Signed-off-by: Kefu Chai <tchaikov@gmail.com>
* CompactionIterator: so initialize "current_user_key_{sequence,snapshot}_" in class.
* RangeTombstone: so initialize seq_ to kMaxSequenceNumber. the default
value is never be read without being reset with a new value afterwards.
* ThreadData: initialize `next` and `prev` to nullptr
* CompactionJob: initialize `bottommost_level_`, this variable will
always be set in `CompactionJob::Prepare()`.
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
|
@siying has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@siying may i know if this PR is relevant ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.