posix writablefile truncate #1894
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajkr
approved these changes
Feb 21, 2017
|
I will add a unit test. |
|
@lightmark updated the pull request - view changes |
|
@lightmark has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
siying
pushed a commit
that referenced
this pull request
Feb 23, 2017
Summary: we occasionally missing this call so the file size will be wrong Closes #1894 Differential Revision: D4598446 Pulled By: lightmark fbshipit-source-id: 42b6ef5
lightmark
added a commit
that referenced
this pull request
Feb 24, 2017
Summary: we occasionally missing this call so the file size will be wrong Closes #1894 Differential Revision: D4598446 Pulled By: lightmark fbshipit-source-id: 42b6ef5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we occasionally missing this call so the file size will be wrong