Remove option min_partial_merge_operands and verify_checksums_in_comp… #1902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@siying has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
yiwu-arbug
approved these changes
Feb 22, 2017
HISTORY.md
Outdated
| @@ -3,6 +3,8 @@ | |||
| ### Public API Change | |||
| * Remove disableDataSync option. | |||
| * Remove timeout_hint_us option from WriteOptions. The option has been deprecated and has no effect since 3.13.0. | |||
| * Remove option min_partial_merge_operands. | |||
| * Remove option verify_checksums_in_compaction. | |||
There was a problem hiding this comment.
Mention the default behavior here after removal?
…action Summary: The two options are not seldom used. Remove them to reduce the total number of options. Also remove them from Java and C interface. Test Plan: Run all unit tests.
siying
force-pushed
the
delete-options2
branch
from
e54404b
to
12f1af9
Compare
|
@siying updated the pull request - view changes - changes since last import |
|
Mention the behavior after removing the options. |
|
The Travis timeout is unrelated. I'm landing it. |
|
@siying has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…action
Summary: The two options, min_partial_merge_operands and verify_checksums_in_compaction, are not seldom used. Remove them to reduce the total number of options. Also remove them from Java and C interface.
Test Plan: Run all unit tests.