Fix flaky DBTestUniversalCompaction.UniversalCompactionTrivialMoveTest2 #1911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: A previous fix to DBTestUniversalCompaction.UniversalCompactionTrivialMoveTest2 didn't address the right problem. The problem is L0->L0 compaction is not trivial move in the scenario, not parallel compactions. Fix this. Test Plan: Run the test multiple times.
|
@siying has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
ajkr
approved these changes
Feb 24, 2017
| @@ -1044,7 +1046,7 @@ TEST_P(DBTestUniversalCompaction, UniversalCompactionTrivialMoveTest2) { | |||
| options.num_levels = 15; | |||
| options.write_buffer_size = 100 << 10; // 100KB | |||
| options.level0_file_num_compaction_trigger = 8; | |||
| options.max_background_compactions = 1; | |||
| options.max_background_compactions = 2; | |||
There was a problem hiding this comment.
just wondering why increment this one?
There was a problem hiding this comment.
Because I previously tried to restrict it to 1 to fix the test but it doesn't seem to be the cause of the problem: 1d9dbef
I'm reverting it to get back the coverage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: A previous fix to DBTestUniversalCompaction.UniversalCompactionTrivialMoveTest2 didn't address the right problem. The problem is L0->L0 compaction is not trivial move in the scenario, not parallel compactions. Fix this.
Test Plan: Run the test multiple times.