java dependencies test -s -> use test -d

[grooverdan]

To correct a build process where the JAVA_TEST_LIBDIR is a symlink to a cache directory.

Test -s (size 0) on symlinks returns true, resulting in a mkdir over the top of the symlink resulting in failure.

As a solution -d checks if it is a directory (or the symlink refers to a directory), which works in the case of real directories and symlinks to directories.

Trivial I know but it was really easy for me to use a symlink here to prevent frequent downloads in a CI environment.

Thanks for your consideration.

[facebook-github-bot]

@siying has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[grooverdan]

I know such a trivial patch is low priority and this is also low risk. Can this be merged and if some unexpected failure occurs on someone's CI then it can be revered. Using this patch the dependence of the travis builds on search.maven.org can be reduced using the cache -> directories option. Happy to do a patch there if merged.

[adamretter]

@siying sounds good to me.

[grooverdan]

thankyou.

[siying]

@grooverdan sorry for the delay. We migrated the internal system a little bit so I committed to a wrong place. Now I fixed it.

[grooverdan]

thanks for letting me know. I'll take a look.

[siying]

@grooverdan oh I already fixed it. I just tried to explain why it took me so long.

[grooverdan]

all good :-) have a good day.