Divide external_sst_file_test #1923
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siying
requested review from
maysamyabandeh,
lightmark,
IslamAbdelRahman,
yiwu-arbug and
ajkr
IslamAbdelRahman
approved these changes
Feb 27, 2017
|
@siying updated the pull request - view changes |
|
@siying has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Summary: Separate the platform dependent tests from external_sst_file_test. Only those tests need to run on platforms like OSX Test Plan: Run these two tests. Reviewers: Subscribers: Tasks: Blame Revision:
|
@siying updated the pull request - view changes - changes since last import |
|
@siying has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Separate the platform dependent tests from external_sst_file_test. Only those tests need to run on platforms like OSX
Test Plan: Run these two tests.