Separate small subset tests in DBTest #1924
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siying
requested review from
maysamyabandeh,
lightmark,
IslamAbdelRahman,
yiwu-arbug and
ajkr
|
@siying has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
I am not sure what's special about these tests (read only, compacted db, ...) that they need to run on Mac but other tests dont |
|
@IslamAbdelRahman I just try to find a small subset of tests so that most platform dependent code is covered. |
IslamAbdelRahman
approved these changes
Feb 27, 2017
siying
force-pushed
the
divide_db_test
branch
from
3b0c849
to
9d541bf
Compare
|
@siying updated the pull request - view changes - changes since last import |
siying
force-pushed
the
divide_db_test
branch
from
9d541bf
to
91a4ce9
Compare
|
@siying updated the pull request - view changes - changes since last import |
Summary: Separate a smal subset of tests in DBTest to DBBasicTest. Tests in DBTest don't have to run in CI tests on platforms like OSX, as long as they are covered by Linux. Test Plan: Run both of db_test and db_basic_test
siying
force-pushed
the
divide_db_test
branch
from
91a4ce9
to
d7657f0
Compare
|
@siying updated the pull request - view changes - changes since last import |
|
@siying has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Separate a smal subset of tests in DBTest to DBBasicTest. Tests in DBTest don't have to run in CI tests on platforms like OSX, as long as they are covered by Linux.
Test Plan: Run both of db_test and db_basic_test