Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sanitize readahead when direct read enabled #1945

Closed
wants to merge 2 commits into from
Closed

sanitize readahead when direct read enabled #1945

wants to merge 2 commits into from

Conversation

lightmark
Copy link
Contributor

@lightmark lightmark commented Mar 2, 2017 •
edited
Loading

./db_bench --benchmarks=fillrandom --write_buffer_size=200000 --num=1000000
HDD
０ readahead: 6079 ops/sec
2MB readahead: 6117 sops/sec

@facebook-github-bot
Copy link
Contributor

@lightmark updated the pull request - view changes

@facebook-github-bot
Copy link
Contributor

@lightmark has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@siying
Copy link
Contributor

siying commented Mar 3, 2017

I still don't understand your benchmark results. What storage media is it, and how many keys did you insert?

siying
siying approved these changes Mar 3, 2017
View reviewed changes
Copy link
Contributor

@siying siying left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diff itself it OK to me though. Please fix the benchmark results in the summary. Or maybe you don't need that. This is straight-forward enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siying siying siying approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lightmark @facebook-github-bot @siying