add max to histogram stats #1968
Conversation
|
@ajkr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
| @@ -411,6 +411,9 @@ struct HistogramData { | |||
| double percentile99; | |||
| double average; | |||
| double standard_deviation; | |||
| // zero-initialize new members since old Statistics::histogramData() | |||
There was a problem hiding this comment.
LGTM, but I don't understand this comment. What is the problem with old implementations ?
There was a problem hiding this comment.
if a user has an old subclass of Statistics, their implementation of histogramData() won't write anything to max until they update it. I updated ours via the change in util/histogram.cc, which is used by StatisticsImpl::histogramData()
|
@ajkr updated the pull request - view changes - changes since last import |
|
@ajkr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@ajkr updated the pull request - view changes - changes since last import |
|
@ajkr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@ajkr updated the pull request - view changes - changes since last import |
|
@ajkr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Domas enlightened me about p100 (i.e., max) stats. Let's add them to our histograms.
Test Plan: