avoid ftruncate twice in buffered io #1991
Conversation
|
@lightmark has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
util/io_posix.cc
Outdated
| s = IOError(filename_, errno); | ||
| } else { | ||
| filesize_ = size; | ||
| if (use_direct_io()) { |
There was a problem hiding this comment.
I think this logic should happen in WritableFileWriter. It's more straight-forward if File::Truncate() always truncates.
|
@lightmark updated the pull request - view changes - changes since last import |
lightmark
force-pushed
the
no_truncate_in_buffered_io
branch
from
0574209
to
82a0ca8
Compare
|
@lightmark updated the pull request - view changes - changes since last import |
|
@lightmark updated the pull request - view changes - changes since last import |
|
@lightmark has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
| @@ -184,11 +184,14 @@ Status WritableFileWriter::Close() { | |||
|
|
|||
| s = Flush(); // flush cache to OS | |||
|
|
|||
| Status interim; | |||
There was a problem hiding this comment.
Now this can happen in line 191?
There was a problem hiding this comment.
line 198 also needs this
| Status interim = writable_file_->Truncate(filesize_); | ||
| if (!interim.ok() && s.ok()) { | ||
| s = interim; | ||
| if (use_direct_io()) { |
There was a problem hiding this comment.
Please make sure it works on Windows.
There was a problem hiding this comment.
Yes. WinWritableFile::use_direct_io() exists already
in buffered io, the filesize_ is the real size.