Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added SstFileWriter construtor without explicit comparator to JNI api #2028

Conversation

mikhail-antonov
Copy link
Contributor

@adamretter
Copy link
Collaborator

@mikhail-antonov Can you add a unit test please?

@facebook-github-bot
Copy link
Contributor

@siying has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@mikhail-antonov updated the pull request - view changes - changes since last import

@facebook-github-bot
Copy link
Contributor

@IslamAbdelRahman has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link
Contributor

@IslamAbdelRahman IslamAbdelRahman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

IslamAbdelRahman pushed a commit that referenced this pull request Apr 4, 2017
Summary:
Adding API missing after 1ffbdfd#diff-b94146418eed4a9c1bf324041b95b279.

adamretter  IslamAbdelRahman

Tested locally.
Closes #2028

Differential Revision: D4762817

Pulled By: IslamAbdelRahman

fbshipit-source-id: 833f478
rockeet added a commit to topling/toplingdb that referenced this pull request Jul 9, 2020
commit 3a95b8e69b1738e3c53dbfd6bab1aa1f344c9a25
Author: rockeet <rockeet@gmail.com>
Date:   Fri Jun 26 20:40:18 2020 +0800

    revert to ZhaoMing smallest()/largest(), make diff with upstream

commit 442963875b102e3f8be61f1b085ea58e97f357e9
Author: rockeet <rockeet@gmail.com>
Date:   Fri Jun 26 20:38:05 2020 +0800

    CMakeLists.txt: Add terark includes

commit 21e3b29e02deafeff162bc64cea10098bc51dedf
Author: rockeet <rockeet@gmail.com>
Date:   Fri Jun 26 18:05:26 2020 +0800

    db_impl_compaction_flush.cc: revert to upstream bad style

commit 39b4317a5ac52f1b67eb915c6fba8d406987a7b4
Author: rockeet <rockeet@gmail.com>
Date:   Fri Jun 26 15:48:49 2020 +0800

    Add more assert

commit 995f0b7f9472668e4a8ae290b6a8ca01db81b2ec
Author: rockeet <rockeet@gmail.com>
Date:   Fri Jun 26 15:34:35 2020 +0800

    min diff && add some assert

commit 95ad63472fecd208c3e27e786f8be9fa4127b67b
Author: rockeet <rockeet@gmail.com>
Date:   Fri Jun 26 14:59:12 2020 +0800

    FileMetaData: smallest/largest use __declspec(property) for min diff with upstream

commit 1e97a2bf1c3a6691bf9042fdca5ba20a01472e5b
Author: rockeet <rockeet@gmail.com>
Date:   Fri Jun 26 13:47:31 2020 +0800

    disable tcmalloc

commit d0e08048c76a1fa31607b52e8f211de048299ff6
Author: rockeet <rockeet@gmail.com>
Date:   Fri Jun 26 13:20:02 2020 +0800

    disable tcmalloc

commit 97791c122286f12952026c6c2d68eab67d819d76
Author: rockeet <rockeet@gmail.com>
Date:   Fri Jun 26 13:06:43 2020 +0800

    min diff: for VersionEdit::AddFile(..)

commit 84cf89b7d0a6230411a97436c5d5921e030f4932
Author: rockeet <rockeet@gmail.com>
Date:   Fri Jun 26 12:46:55 2020 +0800

    fix: remove SetFilterSampleInterval() decl & usage

commit 906750ced23ca0b5f904112283c2a51ca42e2583
Author: rockeet <rockeet@gmail.com>
Date:   Fri Jun 26 12:50:37 2020 +0800

    version_edit_test.cc: fix compile

commit d7b38da7d4c50cb56759f1ba53257f7cddf9bcf4
Author: rockeet <rockeet@gmail.com>
Date:   Fri Jun 26 12:42:23 2020 +0800

    version_builder_test.cc: fix compile

commit 8c9d1d62a4f1ef2899525265b1e1cc181984651f
Author: rockeet <rockeet@gmail.com>
Date:   Fri Jun 26 12:35:41 2020 +0800

    not min diff: delete redundant FileDescriptor::operator=

commit 4acefc1cfc5ec79aa5469e8ab7a11c61c779cf63
Author: rockeet <rockeet@gmail.com>
Date:   Fri Jun 26 11:54:41 2020 +0800

    min diff: fix typo

commit dafedde6d83d5b7dad6bf4ae7e585de1ee59392e
Author: rockeet <rockeet@gmail.com>
Date:   Fri Jun 26 11:48:15 2020 +0800

    min diff: more and more

commit 6a6f66b802496d27cade0a4abfb0438614e09f89
Author: rockeet <rockeet@gmail.com>
Date:   Fri Jun 26 11:04:41 2020 +0800

    min diff: compaction_iterator: revert unecessary improve

commit 6867970831ce337b2414fa81b72aba7d9ddd8767
Author: rockeet <rockeet@gmail.com>
Date:   Fri Jun 26 10:54:56 2020 +0800

    min diff: revert some good changes to bad upstream

commit 22aeb50189f7709c84a4f95e50cd1be4fefd7405
Author: rockeet <rockeet@gmail.com>
Date:   Fri Jun 26 01:57:18 2020 +0800

    git rm db/value_offset_length.h

commit 28442ba5bdb387f615b147cffa5c78babbc77e7d
Author: rockeet <rockeet@gmail.com>
Date:   Fri Jun 26 01:52:39 2020 +0800

    min diff with upstream: remove SourceInternalIterator

commit 30744e97b7cb52b14d671cd21866c9b2e07c3501
Author: rockeet <rockeet@gmail.com>
Date:   Fri Jun 26 01:42:41 2020 +0800

    min diff with upstream - more

commit 1cc41ffa2f42a88965e54f0e3073172bc2ef0e65
Author: rockeet <rockeet@gmail.com>
Date:   Thu Jun 25 23:52:35 2020 +0800

    FileMetaData: smallest/largest as data member, to keep min diff with upstream

commit ebb3d19456ee1794d426fb40c37834f463f51610
Merge: 53849ee54 f65be5755
Author: rockeet <rockeet@gmail.com>
Date:   Thu Jun 25 23:12:02 2020 +0800

    Merge remote-tracking branch 'old-terark/5.9.fb.myrocks.terark.memtable' into 5.9.fb.myrocks.terark

commit 53849ee5462b1ca3d3ed993924e7099cb66de76f
Author: Lei Peng <rockeet@gmail.com>
Date:   Wed Sep 12 14:25:12 2018 +0800

    README.md: minor fix

commit f65be5755f70f728fc7adf943a2cb5f5cfa1f75c
Author: frost <vrofze@gmail.com>
Date:   Tue Aug 28 11:14:56 2018 +0800

    Fix missing break

commit f4135780d3668608bb9a8bdbeefa6021ce160a62
Author: rockeet <rockeet@gmail.com>
Date:   Thu Aug 16 13:30:11 2018 +0800

    util/arena.cc: Remove wrong use of vector.reserve

commit f56e2d2614628ea87111c8e2f74858ba7de94778
Author: 奏之章 <mm304321141@gmail.com>
Date:   Wed Jul 25 21:47:07 2018 +0800

    [WIP] add EstimateWorstSizeAmp

commit 01f213e5762a4acf33b2ce390d927c98c8143700
Author: 奏之章 <mm304321141@gmail.com>
Date:   Fri Jul 20 16:05:32 2018 +0800

    Fix assert

commit 652dd72bb1b16858e67a28a464f2ee697b128b63
Author: 奏之章 <mm304321141@gmail.com>
Date:   Fri Jul 20 12:32:38 2018 +0800

    MemtableRepFactory more params

commit 74507f30a65de2e74a6f9a2b78a6e4e4bb16c5ba
Author: 奏之章 <mm304321141@gmail.com>
Date:   Tue Jul 17 12:20:37 2018 +0800

    Fix missing virtual

commit 988d857b487f56e75f4d9dd1657dd6645df7e24a
Author: 奏之章 <mm304321141@gmail.com>
Date:   Thu Jul 12 17:42:33 2018 +0800

    Add IteratorSource
    WriteBatchEntryIndexFactory add context

commit cfce2dfbee3c272efc6b05ce10639e0bb986e0f8
Merge: c2dceb427 841ec5c46
Author: frost <vrofze@gmail.com>
Date:   Mon Jul 9 16:33:23 2018 +0800

    Merge branch '5.9.fb.myrocks.terark' into 5.9.fb.myrocks.terark.memtable

commit c2dceb427ad583a07232a433c7128dfad8b5f9eb
Author: 奏之章 <mm304321141@gmail.com>
Date:   Fri Jun 29 18:29:48 2018 +0800

    Add __declspec(empty_bases)

commit 435d7979b4c19f0e41162f1b80a6f65bcdde19cb
Author: frost <vrofze@gmail.com>
Date:   Thu Jun 28 18:02:43 2018 +0800

    Fix for gcc

commit 366679b1ed5ba64444c427038db9f8d9ffcb8a8c
Author: 奏之章 <mm304321141@gmail.com>
Date:   Thu Jun 28 17:26:03 2018 +0800

    [WIP] ...

commit a56d607ad208070ba607a30dd465766f81d0ae80
Author: 奏之章 <mm304321141@gmail.com>
Date:   Thu Jun 28 11:36:25 2018 +0800

    [WIP] ...

commit 6e0eaee9d260660a1484cfa41001ac3f3d1e227a
Author: 奏之章 <mm304321141@gmail.com>
Date:   Thu Jun 28 00:56:36 2018 +0800

    [WIP] ...

commit 841ec5c46e80fe25b09e67d7f66d6211f0b5b435
Author: vrofze <vrofze@gmail.com>
Date:   Thu Jun 21 11:42:07 2018 +0800

    Fix typo

commit b1da748b5fce65c309f074861dbe52afdc5463c9
Author: vrofze <vrofze@gmail.com>
Date:   Tue Jun 19 17:39:48 2018 +0800

    Update comment

commit f4d2d8346b98dd8e332601f63d564233196d266d
Author: vrofze <vrofze@gmail.com>
Date:   Tue Jun 19 16:45:52 2018 +0800

    Add parameters to set WriteBatchEntryIndexFactory

commit 55d9db787cfa1137d6cd42030f7a317d5bf5e738
Author: 奏之章 <mm304321141@gmail.com>
Date:   Mon Jun 11 20:10:58 2018 +0800

    Support regist third-party WriteBatchEntryIndexFactory

commit d2feb7cb50acf87cd64a218afe99c98a1c5c0b2f
Author: 奏之章 <mm304321141@gmail.com>
Date:   Mon Jun 11 18:14:00 2018 +0800

    Add comments & const

commit 9f8ee30ace2b4d6903e6c5c65192cc9b33bfe20b
Author: 奏之章 <mm304321141@gmail.com>
Date:   Mon Jun 11 17:54:44 2018 +0800

    Add WriteBatchEntryIndexFactory

commit e27d419e307428cf5098d9d2b96c7a87c3fe4b4b
Author: 奏之章 <mm304321141@gmail.com>
Date:   Sun Jun 10 10:36:50 2018 +0800

    WriteBatchWithIndex minor improvement

commit d1286821c1272d10f1897d51f717289d2a0d02f7
Author: 奏之章 <mm304321141@gmail.com>
Date:   Fri Jun 8 20:38:34 2018 +0800

    Refactor WriteBatchWithIndex for performance

commit af69357c0eabfc5911e934b9213fbceb7d42fcc9
Author: vrofze <vrofze@gmail.com>
Date:   Fri Jun 8 14:35:13 2018 +0800

    Fix last commit bug

commit 9121b3cebcb750d4139fc44fa5a6ac1022c1cb7f
Author: 奏之章 <mm304321141@gmail.com>
Date:   Thu Jun 7 19:34:46 2018 +0800

    Modify for https://github.com/Terark/pub-task/issues/1

commit f102374127b7325607d7b37341b31729d4f3dbb8
Author: 奏之章 <mm304321141@gmail.com>
Date:   Thu Jun 7 15:12:14 2018 +0800

    Delay verify  compaction output table

commit 0fcc3a4b6fb6abfce4ebf4f3bfafccbdd051c8fa
Author: rockeet <rockeet@gmail.com>
Date:   Thu May 31 15:32:22 2018 +0800

    options.h: Add DBOptions::seq_per_batch to make [5.9.fb.myrocks.terark] compatible to [5.9.2]

commit 848993929d4d0c4806b37ee2c1b6dc0568a77aa1
Author: 奏之章 <mm304321141@gmail.com>
Date:   Wed May 30 17:48:24 2018 +0800

    Minor fix

commit 075284be7d3b337a9dc44148794fe35382aac2ab
Author: 奏之章 <mm304321141@gmail.com>
Date:   Tue May 29 10:49:02 2018 +0800

    Fix VersionStorageInfo::EstimateLiveDataSize seg fault

commit 9cb0785b903fde06be503387a12bcb84ac17d26b
Author: rockeet <rockeet@163.com>
Date:   Sat May 26 19:27:10 2018 +0800

    db/compaction_picker_universal.cc: relax qlev --> Add comments more

commit 18ddd7461af8f0cdca4579e513238bd953e70244
Author: rockeet <rockeet@163.com>
Date:   Sat May 26 14:20:23 2018 +0800

    db/compaction_picker_universal.cc: relax qlev --> Add comments

commit 340025eda50765ba39866e17f48bedd6f6077993
Author: rockeet <rockeet@163.com>
Date:   Sat May 26 13:33:33 2018 +0800

    db/compaction_picker_universal.cc: suppress redundant log

commit 1956c031fcc5c770dd36bc79e17b1d10ef0f9a59
Author: rockeet <rockeet@163.com>
Date:   Sat May 26 12:20:09 2018 +0800

    db/compaction_picker_universal.cc: relax qlev when there is no active compaction

commit 1587caf20eabbc482a0e018a7e33b8974ca36b7d
Author: rockeet <rockeet@gmail.com>
Date:   Fri May 25 18:01:10 2018 +0800

    db/compaction_picker_universal.cc: repick: improve - 2

commit 07c92587dd423bb33c80a491ca8bb91c419b782c
Author: rockeet <rockeet@gmail.com>
Date:   Fri May 25 17:54:16 2018 +0800

    db/compaction_picker_universal.cc: repick: improve

commit 23419067b9270ce457e255f5ec94a0a66cc77840
Author: rockeet <rockeet@gmail.com>
Date:   Fri May 25 16:56:10 2018 +0800

    db/compaction_picker_universal.cc: Add re_pick

commit a15280bf2e241f00d0b79dee46745f78c9d517d2
Author: rockeet <rockeet@gmail.com>
Date:   Thu May 24 16:52:20 2018 +0800

    port_posix.cc: Mutex::Mutex() init locked_ - fix

commit 32da63d27fdedddb33327ca5797249468c82095d
Author: 奏之章 <zouzhizhang@qq.com>
Date:   Thu May 24 16:36:20 2018 +0800

    Fix last flags redeclare

commit e0aec1f40f38560d0d5a38ad2bc5dc1229a6760c
Author: rockeet <rockeet@gmail.com>
Date:   Thu May 24 11:42:06 2018 +0800

    port_posix.cc: Mutex::Mutex() init locked_

commit c7682fc2e4302d8706dd0a97eaf928a9e8024189
Author: rockeet <rockeet@gmail.com>
Date:   Thu May 24 11:39:17 2018 +0800

    options/cf_options.cc: by eclipse: init info_log_level

commit b49ca6ad57bac8a7df67671c1f468eba91ad0f6e
Author: rockeet <rockeet@gmail.com>
Date:   Thu May 24 11:04:58 2018 +0800

    Add mmap populate

commit 63a0f00e1849a9189eb1ca42f8b052116130818a
Author: 奏之章 <mm304321141@gmail.com>
Date:   Wed May 23 17:05:07 2018 +0800

    universal compaction picker skip small sorted runs

commit 538a864dd815d4f4fe539d9664aa22ea929a4364
Author: rockeet <rockeet@gmail.com>
Date:   Wed May 23 14:02:26 2018 +0800

    calc-sst.pl: skip score <= 0

commit 8c2578ba1383c5e6d0a29b2e8bbd2c014188af24
Author: 奏之章 <mm304321141@gmail.com>
Date:   Mon May 21 17:43:48 2018 +0800

    Fix DeleteFilesInRanges bug

commit 04b204e31bd52f55fc5b8812333506509ab81433
Author: rockeet <rockeet@gmail.com>
Date:   Thu May 17 18:22:50 2018 +0800

    db/compaction_picker_universal.cc: minor fix

commit a5b59dede4b1f1d6ab1fda6708ed4ed7ae7b170c
Author: rockeet <rockeet@gmail.com>
Date:   Thu May 17 18:16:00 2018 +0800

    db/compaction_picker_universal.cc: remove second call to PickCompactionToReduceSortedRuns()

commit 08ebe1a35944262f5a5cda23be6afbc34585f027
Author: 奏之章 <mm304321141@gmail.com>
Date:   Thu May 17 18:11:15 2018 +0800

    Add IsPickFail flag

commit 3b6d26882cfbeeaf887cc48dec30028ab6ec2cf6
Author: rockeet <rockeet@gmail.com>
Date:   Thu May 17 18:05:44 2018 +0800

    db/compaction_picker_universal.cc: minor fix

commit eee836381c307b9985c4a60834072d98ff98d3f3
Author: rockeet <rockeet@gmail.com>
Date:   Thu May 17 17:57:22 2018 +0800

    db/compaction_picker_universal.cc: minor fix

commit 7d9af71d8319b3bcf496459119309a33a79bafd6
Author: rockeet <rockeet@gmail.com>
Date:   Thu May 17 17:37:01 2018 +0800

    db/compaction_picker_universal.cc: rename sorting_idx to rank

commit 586ed3d5306d5cf412e22590ae30afa421fabb3c
Author: rockeet <rockeet@gmail.com>
Date:   Thu May 17 17:30:21 2018 +0800

    db/compaction_picker_universal.cc: simplify: ignore size_ratio and stop_style

commit 4fe2e0b308ab3822c893252443bfa9a53d6584ee
Author: 奏之章 <mm304321141@gmail.com>
Date:   Wed May 16 16:24:47 2018 +0800

    Fix partial remove under LevelCompaction bug
    Fix UniversalCompaction::NeedsCompaction bug

commit 508feecadde2a02bc98523f3c74a0c917ba99ac3
Author: 奏之章 <zouzhizhang@qq.com>
Date:   Wed May 16 13:30:35 2018 +0800

    Fix trb bug

commit 8a09ed1580e0fef44a51c21824c80b4bd0da9d1d
Merge: 3a459b5bb 168a5b8c7
Author: 奏之章 <zouzhizhang@qq.com>
Date:   Wed May 16 10:40:42 2018 +0800

    Merge branch '5.9.fb.myrocks.terark.dev' into 5.9.fb.myrocks.terark

commit 168a5b8c7c7ace8b2782d166342c30aaa03e9926
Author: 奏之章 <mm304321141@gmail.com>
Date:   Wed Apr 25 11:52:21 2018 +0800

    add DeleteFilesInRanges interface

commit abfc998e946f8c2786fef0a17cd06f326588c71f
Author: 奏之章 <mm304321141@gmail.com>
Date:   Thu Apr 19 14:14:21 2018 +0800

    Fix table_cache NewIterator clean function

commit 757d4d09079433b996ffa06683ea88ee8d76fc99
Author: 奏之章 <mm304321141@gmail.com>
Date:   Thu Mar 1 16:44:08 2018 +0800

    Fix threaded_rbtree_approximate_rank_ratio param

commit 11abcc99c69fe12cbcd27bdc57ceadb8d21128c4
Author: 奏之章 <mm304321141@gmail.com>
Date:   Tue Feb 27 14:39:26 2018 +0800

    Refactor & fix bug TRBTreeRep

commit c63bfd6873430f33caf5ca8b733e4a1ee029f2b5
Author: 奏之章 <mm304321141@gmail.com>
Date:   Mon Feb 26 17:17:49 2018 +0800

    Disable UniversalCompactionPicker::PickCompactionToReduceSizeAmp

commit 9000ad9fa078c3fba98d212ceafc504f4bc1a1ce
Author: 奏之章 <mm304321141@gmail.com>
Date:   Mon Feb 26 15:44:59 2018 +0800

    Fix LRUCacheShard::Insert resize assert

commit 4ac5dcb85504ea0364badae86fb8c25af15f0d03
Merge: e9f3e93cc ed783d215
Author: 奏之章 <mm304321141@gmail.com>
Date:   Mon Feb 26 10:22:56 2018 +0800

    Merge pull request #1 from Terark/5.9.fb.myrocks.terark.dev.multitrb

    5.9.fb.myrocks.terark.dev.multitrb

commit e9f3e93cc6da9a7b9c3641117a20a1ceef6b2e2a
Author: 奏之章 <mm304321141@gmail.com>
Date:   Sat Feb 24 11:20:04 2018 +0800

    Fix miss continue compact pick bug

commit a64550440ac492d06d7304989b73c22579b722f0
Author: 奏之章 <mm304321141@gmail.com>
Date:   Sat Feb 24 10:52:45 2018 +0800

    Fix fake assert

commit ed783d21515c4f11b345336882acd751f034308d
Author: 奏之章 <mm304321141@gmail.com>
Date:   Sun Jan 28 16:52:55 2018 +0800

    Fix warnings

commit 759837008b1d373a867ae00f3d2464d77f25570d
Author: 奏之章 <mm304321141@gmail.com>
Date:   Sun Jan 28 15:18:42 2018 +0800

    Fix TRBTreeRep::Iterator next/prev bug

commit 88465f308df337093fe6a3c28f71a5e3c0413b4b
Author: 奏之章 <mm304321141@gmail.com>
Date:   Sat Jan 27 15:25:06 2018 +0800

    Minor fix

commit 6d6fdb8dfcd966ca93cd7a56ef72c10217b92ceb
Author: 奏之章 <zouzhizhang@qq.com>
Date:   Fri Jan 26 21:19:11 2018 +0800

    Fix trbtreerep bug

commit 82301407b5355902a0c0961b1a0f7573fa1d9b16
Author: 奏之章 <mm304321141@gmail.com>
Date:   Thu Jan 25 21:07:15 2018 +0800

    Add comments

commit df38fabf4b4ca60843f8cda0512998a139b0437b
Author: 奏之章 <mm304321141@gmail.com>
Date:   Thu Jan 25 18:18:42 2018 +0800

    Minor fix ... add comments

commit 218495542dfc03ab922d25014b5536c6678bae19
Author: 奏之章 <mm304321141@gmail.com>
Date:   Thu Jan 25 15:59:59 2018 +0800

    threaded_rbtree_node_t simplize

commit c80a2bf189b70344ef6856976f59d14c3eb1c363
Author: 奏之章 <mm304321141@gmail.com>
Date:   Thu Jan 25 20:06:23 2018 +0800

    Minor mix

commit 21ddad8d5c8223fdf01260a54249bc094fd5ca2c
Author: 奏之章 <mm304321141@gmail.com>
Date:   Thu Jan 25 12:55:07 2018 +0800

    Fix testcase compile error

commit 058aaaf63151daefab9ab3a12e076f08c5b4acbd
Author: 奏之章 <mm304321141@gmail.com>
Date:   Thu Jan 25 12:30:29 2018 +0800

    Fix version_edit_test.cc

commit 02a96328f1cc20f85bc99e1b767f86a86cfbdadf
Author: rockeet <rockeet@gmail.com>
Date:   Thu Jan 25 12:16:15 2018 +0800

    Fix testcase compile error

commit 479c782c5bb94f08ef5b3fc96a1307168352daf9
Author: rockeet <rockeet@gmail.com>
Date:   Thu Jan 25 12:04:41 2018 +0800

    db/db_test_util.h: fix var name shadow

commit 8ba33a61eb085a4586950c4ad27613e406190d3a
Author: rockeet <rockeet@gmail.com>
Date:   Thu Jan 25 11:44:20 2018 +0800

     Cache::Insert(..) add param accept_existing - minor fix

commit ac56e797e0dfd23c8eed894c458937628717b89f
Author: rockeet <rockeet@gmail.com>
Date:   Thu Jan 25 11:35:11 2018 +0800

    Cache::Insert(..) add param accept_existing

commit ad25db7c3ebe1bba79809d6614f818fd13e4207a
Author: 奏之章 <mm304321141@gmail.com>
Date:   Thu Jan 25 10:37:16 2018 +0800

    Minor fix

commit 7fe7022460e8f3f5960aad1e59de0b643fa6ad7e
Author: 奏之章 <mm304321141@gmail.com>
Date:   Thu Jan 25 10:17:33 2018 +0800

    Bug fix & ApproximateNumEntries impl

commit 74c2cde544810b62bb26f546f442eb5e5e5f64f7
Author: 奏之章 <mm304321141@gmail.com>
Date:   Thu Jan 25 01:20:26 2018 +0800

    Refactor TRBTreeRep

commit c289e8e0aa08fc530dfe9c95db8ce5a9e3926688
Author: 奏之章 <mm304321141@gmail.com>
Date:   Wed Jan 24 21:48:31 2018 +0800

    [WIP]

commit e105a1220a5ca12aa7da164f6bfbf3506de9f483
Author: 奏之章 <mm304321141@gmail.com>
Date:   Tue Jan 23 19:49:54 2018 +0800

    Fix TRBTreeRep::ApproximateNumEntries

commit ba4e8bf500f59d0e390eae4a811baed7fdc4dd1e
Author: 奏之章 <mm304321141@gmail.com>
Date:   Tue Jan 23 19:46:54 2018 +0800

    threaded_rbtree_approximate_rank use double

commit cee2d5bab5eaaadbaf9dc6b088fbc0150f5ef8a0
Author: 奏之章 <mm304321141@gmail.com>
Date:   Tue Jan 23 19:42:55 2018 +0800

    TRBTreeRep support ApproximateNumEntries

commit 6b93efc7a0a03ccc38daec0cfd23c8ebc693b5f7
Author: 奏之章 <mm304321141@gmail.com>
Date:   Tue Jan 23 15:38:07 2018 +0800

    Fix ExternalSstFileIngestionJob dead wait

commit 1e09a79e30fab00446732e3889d18c3c7b59a9aa
Author: 奏之章 <mm304321141@gmail.com>
Date:   Tue Jan 23 11:06:22 2018 +0800

    Add IteratorStorage for WriteBatchWithIndex

commit 44072ae234eaf1a21233dcbde4b3f86864266852
Author: 奏之章 <mm304321141@gmail.com>
Date:   Mon Jan 22 22:58:40 2018 +0800

    Fix WriteBatchEntryRBTree TrbComp bug & use trb_multiset

commit 9cdd50c9e76b770628a2bdc2c91b7da06a192ef8
Author: 奏之章 <mm304321141@gmail.com>
Date:   Mon Jan 22 21:24:51 2018 +0800

    Fix WriteBatchWithIndex rbtree bug

commit 0890f5edfd98b3fb0d8803c4ae882719b6c54523
Author: 奏之章 <mm304321141@gmail.com>
Date:   Mon Jan 22 20:18:52 2018 +0800

    Fix for gcc

commit 27cc15989206a20889c08b75db339e238550c45c
Author: 奏之章 <mm304321141@gmail.com>
Date:   Mon Jan 22 17:11:17 2018 +0800

    WriteBatchWithIndex support other index type

commit ef2f11bd23b4f9c7b6ac694825ac4471a4ce6c5b
Author: 奏之章 <mm304321141@gmail.com>
Date:   Mon Jan 22 16:57:57 2018 +0800

    Fix IngestExternalFile deadlock

commit 4f59b87b8ba34e5b002a61de8b3b8df670d2abba
Author: 奏之章 <mm304321141@gmail.com>
Date:   Mon Jan 22 17:00:33 2018 +0800

    Fix IngestExternalFile assert

commit 8a34ed5a222d7319288e7b1884e183d711afa988
Author: 奏之章 <mm304321141@gmail.com>
Date:   Sun Jan 21 18:14:29 2018 +0800

    Refactor universal CompactRange

commit d5f888bc197665aa33e0c45329b5d83333c2c777
Author: 奏之章 <zouzhizhang@qq.com>
Date:   Sun Jan 21 14:47:49 2018 +0800

    Try fix ingest file same seq_num bug

commit f56a82ccbb57d6fa34b800652ba77992e8f716d7
Author: 奏之章 <zouzhizhang@qq.com>
Date:   Fri Jan 19 18:00:42 2018 +0800

    Fix CompactRange not delete file BUG & minor fix

commit 4c8a3fbc7ee8e6a653383f1c47bfe5b686e552fa
Author: vrofze <vrofze@gmail.com>
Date:   Fri Jan 19 11:58:09 2018 +0800

    Try fix table cache crash when close

commit 9c49876727cb3c98569ba76f75db0a165d793e05
Author: rockeet <rockeet@gmail.com>
Date:   Thu Jan 18 11:53:17 2018 +0800

    refactory: remove TableCache::GetTableReaderFromHandle()

commit dde93465148c1f13a4d5f382b16e790958c6df13
Author: rockeet <rockeet@gmail.com>
Date:   Wed Jan 17 23:20:06 2018 +0800

    db/table_cache.cc: fix concurrent table cache miss for same file

commit 87cc3ddfbeed8e120452c40e4811f8e03a2c8ebc
Author: 奏之章 <zouzhizhang@qq.com>
Date:   Wed Jan 17 15:58:57 2018 +0800

    Minor fix

commit 9719579453d8ddae59118d5d82ef336ce6f7ca93
Author: 奏之章 <zouzhizhang@qq.com>
Date:   Wed Jan 17 13:49:10 2018 +0800

    Fix ExternalSstFileIngestionJob::Fix ExternalSstFileIngestionJob user old version & CompactionStats

commit 7f97d6af85b3f96815870bc15b80625b3f239771
Author: 奏之章 <zouzhizhang@qq.com>
Date:   Wed Jan 17 12:31:42 2018 +0800

    Fix ExternalSstFileIngestionJob assert

commit da37ca53c0c67652fcc87c8034f94e8c69776135
Author: 奏之章 <zouzhizhang@qq.com>
Date:   Wed Jan 17 11:38:40 2018 +0800

    Fix CompactionStats

commit 57d900b21ebb02812969a1f672559b05bea24d2e
Author: 奏之章 <zouzhizhang@qq.com>
Date:   Tue Jan 16 19:27:59 2018 +0800

    Fix Universal ingest sst bug

commit 76a5b3742d5bc6ecb6c5c43428ea8b76d61d14d2
Author: 奏之章 <zouzhizhang@qq.com>
Date:   Tue Jan 16 17:06:12 2018 +0800

    Make Universal CompactRange sync

commit 584d7e580f2adb61372c4f4ab5b0dc7599fdd6f0
Author: 奏之章 <zouzhizhang@qq.com>
Date:   Tue Jan 16 11:43:50 2018 +0800

    Fix Universal CompactRange

commit 714db6fdb62ca184fbc122c95ec9b780d622163a
Author: rockeet <rockeet@gmail.com>
Date:   Mon Jan 15 22:38:19 2018 +0800

    Improve comments for enable_partial_remove

commit 6a676881ebe6c275516016ce9bd364ec17f06e30
Author: 奏之章 <zouzhizhang@qq.com>
Date:   Mon Jan 15 22:33:33 2018 +0800

    Add need_continue_compaction

commit 08d976849b15d8bd6d00e504e0a2503fe136acaf
Author: rockeet <rockeet@gmail.com>
Date:   Mon Jan 15 21:49:17 2018 +0800

    compaction_picker_universal.cc: use std::pow

commit b4165588c1a1156710569986964aacb1c4137dd9
Author: 奏之章 <zouzhizhang@qq.com>
Date:   Mon Jan 15 21:33:34 2018 +0800

    CompactRange use partial remove

commit 33e99beefe9bf5f9a0e030d129792282fe8d4aa2
Author: frost <vrofze@gmail.com>
Date:   Mon Jan 15 20:42:37 2018 +0800

    fix bug in UniversalCompactionPicker::PickCompactionToReduceSizeAmp when adding up all the remaining files

commit f0f291f8a56386b35a896b7ce18c239919e09241
Author: 奏之章 <zouzhizhang@qq.com>
Date:   Mon Jan 15 16:52:05 2018 +0800

    Fix CompactionIteratorToInternalIterator::Seek bug

commit 3a459b5bba5ed969a00e4525eac2636cc06aa14e
Author: rockeet <rockeet@gmail.com>
Date:   Mon Jan 15 16:13:50 2018 +0800

    git add calc-sst.pl

commit 436f75013c6b582b5205d68be9c3e419e3b2d556
Author: terark <terark@localhost.localdomain>
Date:   Mon Jan 15 14:40:36 2018 +0800

    CreateColumnFamily use Terark

commit 8ba342cef3ffc4a299ce370fc9beab6cc8c7c229
Author: 奏之章 <zouzhizhang@qq.com>
Date:   Sun Jan 14 19:23:45 2018 +0800

    Fix last merge

commit 58c7c0b6d0c4715387f6f8d61971a2923b7fa892
Author: 奏之章 <zouzhizhang@qq.com>
Date:   Sun Jan 14 18:25:53 2018 +0800

    Merge branch 'feature1-dev'

commit ee30278cc78fb16b385d8af3af0d0c2652692ddc
Author: rockeet <rockeet@gmail.com>
Date:   Fri Jan 12 17:47:26 2018 +0800

    UniversalCompactionPicker::PickCompactionToReduceSortedRuns: use compensated_file_size instead of size

commit 9080f6ac6b96cd40098f3a7d34c82a77bdb66427
Author: rockeet <rockeet@gmail.com>
Date:   Thu Jan 11 21:04:39 2018 +0800

    UniversalCompactionPicker::PickCompactionToReduceSortedRuns(): ajust xlev = SqrtN(qlev, 2.5)

commit a498aa867891ffcfb9b9a0fedca3f6d9083d939e
Author: rockeet <rockeet@gmail.com>
Date:   Wed Jan 10 15:55:50 2018 +0800

    Add calc-sst.{pl,sh}

commit 340a1acae49d70066f7fb7fa68117dcb9f7d90bd
Author: rockeet <rockeet@gmail.com>
Date:   Wed Jan 10 14:10:00 2018 +0800

    db/db_impl_files.cc: revert change

commit 679dfc7566eac88ba0f1d26fd749fe38c3df7bbe
Author: rockeet <rockeet@gmail.com>
Date:   Wed Jan 10 08:57:25 2018 +0800

    DBImpl::DeleteFile: Bug fix

commit 405bf08dcc638b1e0fe0837e226d02d4d863bce4
Author: rockeet <rockeet@gmail.com>
Date:   Tue Jan 9 21:30:23 2018 +0800

    DBImpl::PurgeObsoleteFiles: Log living files

commit 245ded2ba03e75e55e31a779b63d50960973cdaa
Author: rockeet <rockeet@gmail.com>
Date:   Tue Jan 9 19:47:35 2018 +0800

    DBImpl::DeleteFile: Add log

commit 710f30f20a32d0e0a3018b9bdc3c4d491d43b228
Author: rockeet <rockeet@gmail.com>
Date:   Tue Jan 9 19:27:17 2018 +0800

    VersionSet::VerifyCompactionFileConsistency: Log missing file name

commit 70972f7782726dcc57990878cc66bc8924708c7a
Author: 奏之章 <mm304321141@gmail.com>
Date:   Tue Jan 9 10:30:29 2018 +0800

    Fix candidate_count init bug

commit fee284915126523de0f0dd147e74c1359ae4a7ed
Author: terark <terark@localhost.localdomain>
Date:   Mon Jan 8 20:19:04 2018 +0800

    Fix last commit bugs

commit f20ad69f6abc9f081f0db773a3033e649d8be268
Author: rockeet <rockeet@gmail.com>
Date:   Mon Jan 8 18:53:15 2018 +0800

    UniversalCompactionPicker::PickCompactionToReduceSortedRuns: remove dead code, and add dynamic qlev

commit 3b18c9e2afbe2b624a8db8ac278bcf42f40f351a
Author: rockeet <rockeet@gmail.com>
Date:   Mon Jan 8 14:39:31 2018 +0800

    PrintLevelStats*: adjust format

commit 0a20cbd5f727ccfc9c7f0720cca09665b3e44a83
Author: rockeet <rockeet@gmail.com>
Date:   Mon Jan 8 11:20:29 2018 +0800

    UniversalCompactionPicker::PickCompactionToReduceSortedRuns: fix

commit cb134b4174788e1a18ee6b16a080739170df8916
Author: 奏之章 <mm304321141@gmail.com>
Date:   Mon Jan 8 10:22:19 2018 +0800

    Fix warning in vc

commit 653fa18de36827986f4373e4abf7aa2e2fd3258c
Author: rockeet <rockeet@163.com>
Date:   Sun Jan 7 17:55:57 2018 +0800

    Add strategy has_small_in_middle

commit 7452b62c17f4afe9d16baa6247eb3e75f742d3f1
Author: 奏之章 <mm304321141@gmail.com>
Date:   Sun Jan 7 15:39:24 2018 +0800

    Fix lambda params type

commit dc3443cb61fe047f597123ce04d3046cfe21e2a2
Author: rockeet <rockeet@163.com>
Date:   Sun Jan 7 15:31:09 2018 +0800

    UniversalCompactionPicker::PickCompactionToReduceSortedRuns: use rough sort

commit c6aba3f8b3004f58f75efab34de67c14adf8af4b
Author: rockeet <rockeet@163.com>
Date:   Sun Jan 7 15:24:19 2018 +0800

    UniversalCompactionPicker::PickCompactionToReduceSortedRuns: rename hidding var

commit f65b8089eb6b06bbf63f6f3b9c2ad48f09591daa
Author: rockeet <rockeet@163.com>
Date:   Sun Jan 7 15:23:19 2018 +0800

    UniversalCompactionPicker::PickCompactionToReduceSortedRuns: first sort by size

commit 7ff591bd9cea8642d7b3ffbde8ed574280765ae4
Author: rockeet <rockeet@163.com>
Date:   Sun Jan 7 13:56:52 2018 +0800

    db/compaction_picker_universal.cc: re-ranking after selected candidate - fix 2

commit cfbbd285104792aa893c40d9ede9040ecff9c264
Author: rockeet <rockeet@163.com>
Date:   Sun Jan 7 13:56:52 2018 +0800

    db/compaction_picker_universal.cc: re-ranking after selected candidate - fix

commit e084f79f717cc18073dc736b67691def0b56f855
Author: 奏之章 <mm304321141@gmail.com>
Date:   Sun Jan 7 13:27:59 2018 +0800

    Add an assert

commit a90c6991fd5159d8b6a54d7f9c3c2526215513f8
Author: rockeet <rockeet@163.com>
Date:   Sun Jan 7 13:16:09 2018 +0800

    db/compaction_picker_universal.cc: re-ranking after selected candidate

commit 45f9e65c68f5badb1040d51190a4f166b6699d85
Author: rockeet <rockeet@163.com>
Date:   Sun Jan 7 08:59:10 2018 +0800

    db/compaction_picker_universal.cc: restrict bad picker's max sorted run threshold - consider worst case

commit dc6f06d63950f8d61f7cf9e98c954c428a7536b7
Author: rockeet <rockeet@163.com>
Date:   Sun Jan 7 08:46:31 2018 +0800

    db/compaction_picker_universal.cc: restrict bad picker's max sorted run threshold - relax a little

commit fe668967763ef5785067465575e75855121b5538
Author: rockeet <rockeet@163.com>
Date:   Sun Jan 7 08:40:19 2018 +0800

    db/compaction_picker_universal.cc: restrict bad picker's max sorted run threshold

commit eede87ed001f698dea367c9989fbed3a2b4897af
Author: rockeet <rockeet@163.com>
Date:   Sun Jan 7 08:13:56 2018 +0800

    db/compaction_picker_universal.cc: simplify bad picker and change bad picker's num_files

commit 97b199b5b8a3a085ccfff7231094958eee5daaaf
Author: rockeet <rockeet@163.com>
Date:   Sun Jan 7 07:33:34 2018 +0800

    db/compaction_picker_universal.cc: restrict bad picker

commit 25615c12beb17edc9ac6b4c9f496416115679b5b
Author: rockeet <rockeet@163.com>
Date:   Sun Jan 7 06:17:35 2018 +0800

    db/compaction_picker_universal.cc: revert last change

    because last change will cause lower/bottom level is smaller than upper/top level,
    and this will disturb other strategy

commit f4ba60e94b20d2758934fd11552138b2d66974d3
Author: rockeet <rockeet@163.com>
Date:   Sun Jan 7 05:45:30 2018 +0800

    db/compaction_picker_universal.cc: improve TotalSize with min_merge_with > 2

commit bd9d9ec470824e57827a3369a5cbbebaa5ad2cff
Author: rockeet <rockeet@163.com>
Date:   Sat Jan 6 23:55:21 2018 +0800

    db/compaction_picker_universal.cc: ignore bad pick also for kCompactionStopStyleSimilarSize

commit 5a985dae6c237760129b019e2aeb0d9629c26600
Author: rockeet <rockeet@163.com>
Date:   Sat Jan 6 20:38:24 2018 +0800

    db/column_family.cc: fix min_merge_width adjustion

commit 9de170df53279a5519793de00892b79280c3cd9d
Author: rockeet <rockeet@gmail.com>
Date:   Sat Jan 6 20:21:56 2018 +0800

    db/column_family.cc: a minor fix

commit 831a723b5d04a4462c88b404e9665011bb4aa429
Author: 奏之章 <mm304321141@gmail.com>
Date:   Sat Feb 24 17:44:50 2018 +0800

    Fix kUniversalTrivialMove bug

commit c7f89b533d9fa4195e647d0ebbc0a9fa8ca10585
Author: rockeet <rockeet@163.com>
Date:   Sat Jan 6 17:13:00 2018 +0800

    db/compaction_picker_universal.cc: minor fix

commit 130bb959f7663c55ade235fa134e4a19e609374e
Author: rockeet <rockeet@163.com>
Date:   Sat Jan 6 16:08:16 2018 +0800

    db/compaction_picker_universal.cc: do pick when last is not the max

commit a6c0edfcc776fca6cfa27a5585ce96dab32ab132
Author: rockeet <rockeet@163.com>
Date:   Sat Jan 6 14:19:09 2018 +0800

    db/compaction_picker_universal.cc: do not pick if too bad

commit 78fa64b0133676a964bf4aa71f3c0a19d39e4b26
Author: 奏之章 <mm304321141@gmail.com>
Date:   Fri Jan 5 20:44:39 2018 +0800

    Fix TrivialMovePickCompaction

commit a8d61df81480536a60c4baafd8f4fd170244b102
Author: 奏之章 <zouzhizhang@qq.com>
Date:   Fri Jan 5 20:27:54 2018 +0800

    Add TrivialMovePickCompaction

commit 7c9fe2866b38572a55a49536283c2f2867f25e8e
Author: rockeet <rockeet@gmail.com>
Date:   Fri Jan 5 19:38:51 2018 +0800

    db/compaction_job.cc: revert a good idea with bad realization

commit 78e581a9a3d8217ef82458a4ef167f0a2102e3d1
Author: rockeet <rockeet@gmail.com>
Date:   Fri Jan 5 19:37:11 2018 +0800

    db/compaction_picker_universal.cc: skip bad compaction candidate

commit 0fd686cfad219f09f7578749d1af115949d51a6e
Author: 奏之章 <mm304321141@gmail.com>
Date:   Fri Jan 5 16:18:52 2018 +0800

    Disable DeleteFile check & trbtree memtable param set to 1

commit 38071a74355511558fca426a0b58ae6be5efa2fb
Author: rockeet <rockeet@gmail.com>
Date:   Thu Jan 4 15:24:17 2018 +0800

    Makefile: add var TERARK_ZIP_ROCKSDB_HOME

commit 8e4d8585ba518dc31f188dd0623efe8c90a56922
Author: rockeet <rockeet@gmail.com>
Date:   Wed Jan 3 18:26:07 2018 +0800

    compaction_job.cc: allow more writes and other compactions during a compaction run - fix 2

commit 4a9d61bd671209660b57ea24667312728dcf8406
Author: rockeet <rockeet@gmail.com>
Date:   Wed Jan 3 17:22:11 2018 +0800

    compaction_job.cc: allow more writes and other compactions during a compaction run - fix

commit c06bb5cd858ddb6c43cb794f8dbf0cb4eb14842f
Author: rockeet <rockeet@gmail.com>
Date:   Wed Jan 3 17:09:39 2018 +0800

    compaction_job.cc: allow more writes and other compactions during a compaction run

commit 29078c0883238517a878a9d84ebfc46637b76690
Author: rockeet <rockeet@gmail.com>
Date:   Wed Jan 3 16:16:37 2018 +0800

    fix eclipse warnings

commit 2f56eedad29d63aa97dd3ca65ae72ac004e9da77
Author: rockeet <rockeet@gmail.com>
Date:   Fri Dec 29 19:48:14 2017 +0800

    minor fix

commit f0aa8770b4f67b5672e888e1de8296b97b6b7437
Author: rockeet <rockeet@gmail.com>
Date:   Fri Dec 29 19:45:23 2017 +0800

    change memtable_factory as semi-mutable - minor fix

commit d3c811a6b72cce98bd24f9da5c200643318b7ed7
Author: rockeet <rockeet@gmail.com>
Date:   Fri Dec 29 19:30:08 2017 +0800

    change memtable_factory as semi-mutable

commit e84c587840abf3f667000a0c20eb8699d396580f
Author: rockeet <rockeet@gmail.com>
Date:   Fri Dec 29 17:20:57 2017 +0800

    minor fix for eclipse

commit 826b0a1fb1b5f679fc9bafdbb607cc8cfea4d82c
Author: 奏之章 <zouzhizhang@qq.com>
Date:   Fri Dec 29 17:10:41 2017 +0800

    Add rbtree option

commit e6db33c6f0ae2e40142fdcae152718bd978220bf
Author: rockeet <rockeet@gmail.com>
Date:   Fri Dec 29 15:23:36 2017 +0800

    check permission for env TerarkZipTable_localTempDir - fix 3

commit c239c72c4c4a355728a4ae70797f2641748cb66c
Author: rockeet <rockeet@gmail.com>
Date:   Fri Dec 29 15:22:11 2017 +0800

    check permission for env TerarkZipTable_localTempDir - fix 2

commit fc7127685a1b556bb35e5a135884017e40b6cf69
Author: rockeet <rockeet@gmail.com>
Date:   Fri Dec 29 15:19:29 2017 +0800

    check permission for env TerarkZipTable_localTempDir

commit e44adf823bcb461765d045957aa70a2934f8da71
Author: 奏之章 <zouzhizhang@qq.com>
Date:   Thu Dec 28 16:01:53 2017 +0800

    Fix CompactionIteratorToInternalIterator::Seek bug

commit f6ed234dc898dbda97d1cdc4366f88a8e72eac67
Author: 奏之章 <zouzhizhang@qq.com>
Date:   Thu Dec 28 14:32:10 2017 +0800

    Fix for cl

commit 4ea4b585b163f0424415341261e3f80f6caeb516
Author: 奏之章 <zouzhizhang@qq.com>
Date:   Thu Dec 28 14:29:45 2017 +0800

    CompactionIteratorToInternalIterator support Seek

commit 418ff0ea32fd1b08aa9d10060d676c9dd43d5a5b
Author: 奏之章 <zouzhizhang@qq.com>
Date:   Thu Dec 28 12:39:11 2017 +0800

    Fix for cl

commit 5894bea7a55bd48f4404a83ab82ac0d85704fc47
Author: 奏之章 <zouzhizhang@qq.com>
Date:   Thu Dec 28 12:25:20 2017 +0800

    Fix for cl

commit f5bef038c3f6efebda1f223720bb469e9b065c35
Author: rockeet <rockeet@gmail.com>
Date:   Thu Dec 28 12:04:42 2017 +0800

    rbtree memtable: fix some bugs from merge

commit 0fcb704d9c2cb493d52846f6aac3942b214fcdc0
Author: rockeet <rockeet@gmail.com>
Date:   Thu Dec 28 11:53:13 2017 +0800

    db/builder.cc: fix bug on code merge

commit bf3c9d3011e5d0a0cb61daaab09af82b96d6ada2
Author: rockeet <rockeet@gmail.com>
Date:   Thu Dec 28 11:34:55 2017 +0800

    Makefile: fix bug on code merge

commit fe7c12a023f1df42e3ba086c2eb308dabb0dc36e
Merge: 0859c7425 ad510dff5
Author: rockeet <rockeet@gmail.com>
Date:   Thu Dec 28 11:18:44 2017 +0800

    Merge branch 'v5.8.0.terark' into 5.9.fb.myrocks.terark for rbtree memtable

commit 0859c7425cc64bd83c88916add174be34041336d
Merge: 4d7b0d528 e6e10d54a
Author: rockeet <rockeet@gmail.com>
Date:   Thu Dec 28 11:14:19 2017 +0800

    merge from v5.8.0.terark@e6e10d5 to 5.9.fb.myrocks@4d7b0d5

commit ad510dff5e40da0a7b9026b87cdd3a5081a54e21
Author: terark <terark@localhost.localdomain>
Date:   Wed Dec 27 18:24:40 2017 +0800

    Use threaded_rbtree instead of threaded_rb_tree in memtable/trbtreerep.cc

commit eaf2de24d3d0629a40fa2532bca952ba3568dd82
Author: terark <terark@localhost.localdomain>
Date:   Wed Dec 27 16:51:46 2017 +0800

    Add trbmemtable

commit e6e10d54a3887b26f234b6e80143ec26e9faac0d
Author: rockeet <rockeet@gmail.com>
Date:   Tue Dec 26 20:04:23 2017 +0800

    Slice::compare: fix false assert

commit e5ed70c2b1db1d4e0b3bffa3a032af44d983a3ef
Author: rockeet <rockeet@gmail.com>
Date:   Tue Dec 26 15:10:15 2017 +0800

    Makefile: pretty format and minor fix

commit b5f5fb729e0d90b0faf6c287d1630e73287d5906
Author: rockeet <rockeet@gmail.com>
Date:   Tue Dec 26 13:40:55 2017 +0800

    db/terark_zip_table_db_test.cc: minor fix

commit bba49a551d0ae8f441f7b791ced80ad70557079b
Author: rockeet <rockeet@gmail.com>
Date:   Tue Dec 26 12:53:51 2017 +0800

    db/column_family.cc: minor fix for gcc warning

commit fbebc78a7edec3281de467deed3ee84cc0d9f671
Author: rockeet <rockeet@gmail.com>
Date:   Tue Dec 26 12:44:42 2017 +0800

    Merge v5.3.3.terark from cfd05ec(2017-10-09, not included this) to v5.8.0.terark

commit 87231a4fd1b2f3d85440cd62c94dd823cb2dd717
Merge: 0e95bc4d6 cfd05ecf1
Author: 奏之章 <zouzhizhang@qq.com>
Date:   Mon Oct 23 16:13:35 2017 +0800

    Merge remote-tracking branch 'origin/v5.3.3.terark' into v5.8.0.terark

commit 0e95bc4d64145d63eb407d132e49190d45296ea1
Merge: e7a32572a 266ac245a
Author: 奏之章 <zouzhizhang@qq.com>
Date:   Tue Oct 17 17:40:55 2017 +0800

    Merge branch 'official' into v5.8.0.terark

commit cfd05ecf1b474cc00d5a879f78068c61cdd8660d
Author: Wbrta <ghlovezxcvbnm@vip.qq.com>
Date:   Mon Oct 9 11:29:04 2017 +0800

    add VersionSet and VersionEdit some getter

commit 161ff7ab92aca28f652af996cf7ecf69d459a6f9
Author: 奏之章 <mm304321141@gmail.com>
Date:   Fri Sep 22 13:30:18 2017 +0800

    Make CompactionIterator::IsShuttingDown public

commit 2e060f159d0e7e86d5ba624c7908d79504f489f6
Author: rockeet <rockeet@gmail.com>
Date:   Thu Sep 21 17:24:25 2017 +0800

    Fix for shutting down

commit d1e3b8515461d9d568e6e23a2176f10f213bcea0
Author: terark <terark@localhost.localdomain>
Date:   Mon Sep 4 18:13:20 2017 +0800

    Fix FD ...

commit 7b632174c1fbb1c78aaa5d9f4f4686135e3c66dd
Author: 奏之章 <mm304321141@gmail.com>
Date:   Mon Aug 28 17:42:48 2017 +0800

    More test

commit d6e5422c12f0011121524b8264b47b415d536f64
Author: rockeet <rockeet@gmail.com>
Date:   Thu Aug 24 14:07:14 2017 +0800

    intprt_t RandomAccessFile::FileDescriptor()

commit 24552e3575d758ef869d411bb623ae475471bea3
Author: terark <terark@localhost.localdomain>
Date:   Tue Aug 22 20:52:18 2017 +0800

    Fix MergingIterator::AddIterator bug

commit 575086f01071d0a36cc71a21d41c057c71233fac
Author: rockeet <rockeet@gmail.com>
Date:   Mon Aug 21 15:52:34 2017 +0800

    EnvPosix::NewRandomAccessFile(): move close(fd) to PosixMmapReadableFile::~PosixMmapReadableFile()

commit c84cea683bb79ea7089521ab83145ed050e1a0d7
Author: 奏之章 <mm304321141@gmail.com>
Date:   Mon Aug 21 11:26:43 2017 +0800

    Fix posix fd impl

commit 5616f89000d2c8387d252ea6fd90f12411f833ed
Author: 奏之章 <mm304321141@gmail.com>
Date:   Fri Aug 18 21:46:18 2017 +0800

    Add WinMmapReadableFile::FileDescriptor()

commit 19ee840daa2fc0daad7ed1d7923e8bc415ca4f16
Author: rockeet <rockeet@gmail.com>
Date:   Fri Aug 18 20:08:36 2017 +0800

    Add RandomAccessFile::FileDescriptor()

commit 12abba4e313581a44adb6627897fea6584f31b75
Author: 奏之章 <mm304321141@gmail.com>
Date:   Thu Aug 17 16:55:36 2017 +0800

    More test

commit e7a32572ace7c3dda521f5ca9f02aa2e1947a409
Author: 奏之章 <zouzhizhang@qq.com>
Date:   Thu Aug 17 11:48:25 2017 +0800

    force use RTTI

commit 6ce725a68d33116fe4c46aee73fbf97c54a3f30d
Author: 奏之章 <zouzhizhang@qq.com>
Date:   Wed Aug 16 18:18:47 2017 +0800

    Fix merge ...

commit 47c03db5a4c2f13e1953ff2aa0aaee7812774005
Merge: e367774d1 b575e0489
Author: 奏之章 <zouzhizhang@qq.com>
Date:   Wed Aug 16 18:11:31 2017 +0800

    Merge 'v5.5.1.terark' into v5.8.0.terark

commit b575e048964c579ec41ee96726dd3f9314dda28e
Merge: ca4d33678 107f0841c
Author: 奏之章 <zouzhizhang@qq.com>
Date:   Wed Aug 16 17:28:38 2017 +0800

    Merge 'v5.3.3.terark' into v5.5.1.terark

commit 107f0841c963a846429f298d6dfbd4af378c5b78
Author: rockeet <rockeet@gmail.com>
Date:   Tue Aug 15 18:06:17 2017 +0800

    ReadTableProperties(): remove unused local object

commit a6fd88e3f122b10c4319d391c3218a6ae512820b
Author: 奏之章 <mm304321141@gmail.com>
Date:   Mon Aug 14 18:08:48 2017 +0800

    Add Delete test on terark_zip_table_reader

commit feea6c9b157b09a343bc096c6e0ce9aec3e5d0ed
Author: 奏之章 <mm304321141@gmail.com>
Date:   Wed Aug 9 14:44:44 2017 +0800

    Update terark zip table test

commit 90c1a0a002c4f99212893dbe5541efea47c65a71
Author: 奏之章 <zouzhizhang@qq.com>
Date:   Sun Jul 23 18:04:00 2017 +0800

    Fix for cl

commit dc1564f2c060b9ed89cf423c2740220f1ac2dd86
Author: rockeet <rockeet@gmail.com>
Date:   Fri Jul 21 16:56:28 2017 +0800

    Initialize Compaction::is_trivial_move_

    Also initialize some uninitialized data members in other classes

commit 3cde43a380374c17477a897b355a778bc799b775
Author: rockeet <rockeet@gmail.com>
Date:   Fri Jul 21 12:29:23 2017 +0800

    Some fixes

commit ba3195626c481e04004a77c626247a99179b5374
Author: 奏之章 <mm304321141@gmail.com>
Date:   Fri Jul 21 10:05:28 2017 +0800

    terark zip table more test

commit ac7a020573c9556825ce9c15c79384381a241450
Author: rockeet <rockeet@gmail.com>
Date:   Thu Jul 20 15:00:53 2017 +0800

    db/column_family.h: minimize diff -w to rocksdb 5.3.3

commit 6eae650339ac15f25cd0d06c972bf8d8afa5705d
Author: rockeet <rockeet@gmail.com>
Date:   Thu Jul 20 14:56:20 2017 +0800

    tools/sst_dump_tool.cc: minimize diff to rocksdb.5.3.3

commit 649d44919f04dad2c03761fe52ebb9ae6feba0a2
Author: rockeet <rockeet@gmail.com>
Date:   Thu Jul 20 14:53:15 2017 +0800

    include/rocksdb/table.h: remove redundant comment

commit 66511febc80963394ac609cb55cbb22910efb757
Author: rockeet <rockeet@gmail.com>
Date:   Thu Jul 20 14:30:53 2017 +0800

    git rm cmake-build-debug/third-party/gtest-1.7.0/fused-src/gtest/Makefile

commit ca4d3367860118214bdb0efd92c2ef0c7657e256
Author: rockeet <rockeet@gmail.com>
Date:   Tue Jul 18 18:48:53 2017 +0800

    db/db_impl.cc: fix typo

commit 114a5d0fa834bfa6e7cb2ea7a6537989b0e9d299
Author: rockeet <rockeet@gmail.com>
Date:   Tue Jul 18 18:40:36 2017 +0800

    mklib.sh: minor fix

commit 43f2c28a656032aee528d90b9e00aa95f011cc35
Merge: 72cf57d4b b52959a47
Author: 奏之章 <zouzhizhang@qq.com>
Date:   Wed Jul 12 18:51:26 2017 +0800

    Merge remote-tracking branch 'origin/master' into v5.5.1

commit b52959a4752300b854e7b66ba93c58f3b07e6ea0
Author: 奏之章 <mm304321141@gmail.com>
Date:   Wed Jul 12 16:23:55 2017 +0800

    Fix makeCompactionIterator param error

     range_del_agg  ->  range_del_agg2

commit 72cf57d4b40e5c809839afc1c62dc13e533b8ec6
Author: sdong <siying.d@fb.com>
Date:   Mon Jun 26 17:47:20 2017 -0700

    Apply CLANG Tidy

commit 769778e2dc2a4e471f08d8519676634d05118fa2
Author: Aaron Gao <gzh@fb.com>
Date:   Mon Jun 26 15:24:46 2017 -0700

    bump version to 5.5.1

commit e2f851e064f95534e191d927e74e40e5d67e6ac3
Author: Siying Dong <siying.d@fb.com>
Date:   Mon Jun 26 12:32:52 2017 -0700

    Fix bug that flush doesn't respond to fsync result

    Summary:
    With a regression bug was introduced two years ago, by https://github.com/facebook/rocksdb/commit/6e9fbeb27c38329f33ae541302c44c8db8374f8c , we fail to check return status of fsync call. This can cause we miss the information from the file system and can potentially cause corrupted data which we could have been detected.
    Closes https://github.com/facebook/rocksdb/pull/2495

    Reviewed By: ajkr

    Differential Revision: D5321949

    Pulled By: siying

    fbshipit-source-id: c68117914bb40700198fc37d0e4c63163a8a1031

commit c3e919a4108ead1a8aec0f7c2fbb387153bc3d2b
Author: 奏之章 <mm304321141@gmail.com>
Date:   Mon Jun 12 18:54:11 2017 +0800

    Fix compaction_job for mongo-rocks

commit 09fce6be706c6d6ebdbb856007290afa6d157b99
Author: Aaron Gao <gzh@fb.com>
Date:   Fri Jun 9 11:06:34 2017 -0700

    update 5.5 change log

    Summary:
    update bug fixed.
    Closes https://github.com/facebook/rocksdb/pull/2434

    Differential Revision: D5218601

    Pulled By: lightmark

    fbshipit-source-id: 1f86b2c93345673612381081537d464e7d12e434

commit e11237da1b0575f1844655fa57fcf9dd39b4242c
Author: rockeet <rockeet@gmail.com>
Date:   Tue Jun 6 14:52:50 2017 +0800

    Makefile: let shared_lib be compiled parallel - fix

commit 25bfcbadd191d86d22c005e38d71287de14149cd
Author: rockeet <rockeet@gmail.com>
Date:   Tue Jun 6 14:07:30 2017 +0800

    Makefile: let shared_lib be compiled parallel

commit fbb53c974590513b166a158c032a7c1a0da20419
Author: 奏之章 <mm304321141@gmail.com>
Date:   Tue Jun 6 14:07:17 2017 +0800

    Fix for cl

commit 343f70fe9b4b4d23921f99429a96b49d2792617e
Author: Adam Retter <adam.retter@googlemail.com>
Date:   Mon Jun 5 12:16:02 2017 -0700

    Switch from CentOS 5 to CentOS 6 for crossbuilding RocksJava

    Summary:
    Updates the statically linked libraries from linking against glibc 2.5, to linking against glibc 2.12.
    Closes https://github.com/facebook/rocksdb/pull/2405

    Differential Revision: D5184132

    Pulled By: sagar0

    fbshipit-source-id: 7a8ad4cf7e737ca62f29e58938bd49fa02114541

commit e15b6f163d0ef338b22efaae3f859dfb3787e52f
Author: rockeet <rockeet@gmail.com>
Date:   Mon Jun 5 20:34:27 2017 +0800

    Add ReadOptions::value_data_offset, value_data_length

commit 11ef67ca570d5dc5459759af16df3029f28a702e
Author: 奏之章 <mm304321141@gmail.com>
Date:   Fri Jun 2 16:07:18 2017 +0800

    TerarkZipTableReader iterator more test

commit 8638b8fb686e3ce5fee9dea7d138e7fb1d08e926
Author: 奏之章 <mm304321141@gmail.com>
Date:   Thu Jun 1 20:05:35 2017 +0800

    TerarkZipTableReader iterator more test

commit cb60842d005246b59344f1fcd8ff2805a4b4794b
Author: Aaron Gao <gzh@fb.com>
Date:   Wed May 24 18:18:51 2017 -0700

    Revert "cross-platform compatibility improvements"

    This reverts commit 11c5d4741a1e11a1315d5ca644ce555e07e91f61.

commit a61e7b5f06c26ba74b7ca032a6c41cdd9cdc6a0e
Author: Aaron Gao <gzh@fb.com>
Date:   Wed May 24 18:18:24 2017 -0700

    Revert "remove #include port/port.h in public header file"

    This reverts commit 4c9d2b10468146f42facb98fbc55d31501036d6a.

commit 1182f63f928078cd818d4449c03d335fd570f54d
Author: Aaron Gao <gzh@fb.com>
Date:   Wed May 24 11:49:35 2017 -0700

    update buckifer/TARGETS

    Summary:
    update targets file for release
    Closes https://github.com/facebook/rocksdb/pull/2358

    Differential Revision: D5115705

    Pulled By: lightmark

    fbshipit-source-id: 96a3c7e15b5807b5d0f5a9bb73850b92754b5794

commit 8fd7fb59e51aa284915f77ddd13b39b5ffbb02fb
Author: Siying Dong <siying.d@fb.com>
Date:   Wed May 24 09:43:32 2017 -0700

    range sync should be enabled

    Summary:
    We forgot to add the new flag in internal build script. Add it.
    Closes https://github.com/facebook/rocksdb/pull/2360

    Differential Revision: D5121428

    Pulled By: siying

    fbshipit-source-id: af72d48cd855b37df1ce3c1fbb00c80377ba6e4f

commit e519921b804070d22f2ce86aab5abc755590672f
Author: Sagar Vemuri <svemuri@fb.com>
Date:   Tue May 23 14:57:32 2017 -0700

    Fix errors in clang-analyzer builds

    Summary:
    Fix build error in db_iter.cc when running clang-analyzer.
    ```
      CC       db/db_iter.o
    db/db_iter.cc:938:21: error: no matching constructor for initialization of 'rocksdb::ParsedInternalKey'
      ParsedInternalKey ikey(Slice(), 0, 0);
                        ^    ~~~~~~~~~~~~~
    ./db/dbformat.h:84:3: note: candidate constructor not viable: no known conversion from 'int' to 'rocksdb::ValueType' for 3rd argument
      ParsedInternalKey(const Slice& u, const SequenceNumber& seq, ValueType t)
      ^
    ./db/dbformat.h:78:8: note: candidate constructor (the implicit copy constructor) not viable: requires 1 argument, but 3 were provided
    struct ParsedInternalKey {
           ^
    ./db/dbformat.h:78:8: note: candidate constructor (the implicit move constructor) not viable: requires 1 argument, but 3 were provided
    ./db/dbformat.h:83:3: note: candidate constructor not viable: requires 0 arguments, but 3 were provided
      ParsedInternalKey() { }  // Intentionally left uninitialized (for speed)
      ^
    1 error generated.
    ```
    Closes https://github.com/facebook/rocksdb/pull/2354

    Differential Revision: D5115751

    Pulled By: sagar0

    fbshipit-source-id: b0e386d4e935e4725b07761c3ca5f7a8cbde3692

commit a1c62c19cc5e0d818ca20a7077b62080e1b7ffda
Author: Sagar Vemuri <svemuri@fb.com>
Date:   Tue May 23 14:52:13 2017 -0700

    Fix release build on Linux

    Summary:
    Release builds are failing on Linux with the error:
    ```
    tools/db_stress.cc: In function ‘int main(int, char**)’:
    tools/db_stress.cc:2365:12: error: ‘rocksdb::SyncPoint’ has not been declared
       rocksdb::SyncPoint::GetInstance()->SetCallBack(
                ^
    tools/db_stress.cc:2370:12: error: ‘rocksdb::SyncPoint’ has not been declared
       rocksdb::SyncPoint::GetInstance()->SetCallBack(
                ^
    tools/db_stress.cc:2375:12: error: ‘rocksdb::SyncPoint’ has not been declared
       rocksdb::SyncPoint::GetInstance()->EnableProcessing();
                ^
    make[1]: *** [tools/db_stress.o] Error 1
    make[1]: Leaving directory `/data/sandcastle/boxes/trunk-git-rocksdb-public'
    make: *** [release] Error 2
    ```
    Closes https://github.com/facebook/rocksdb/pull/2355

    Differential Revision: D5113552

    Pulled By: sagar0

    fbshipit-source-id: 351df707277787da5633ba4a40e52edc7c895dc4

commit fba9d664160afb2331c410dc5a974beb6e2459af
Author: Yi Wu <yiwu@fb.com>
Date:   Tue May 23 10:32:02 2017 -0700

    Fix rocksdb.estimate-num-keys DB property underflow

    Summary:
    rocksdb.estimate-num-keys is compute from `estimate_num_keys - 2 * estimate_num_deletes`. If  `2 * estimate_num_deletes > estimate_num_keys` it will underflow. Fixing it.
    Closes https://github.com/facebook/rocksdb/pull/2348

    Differential Revision: D5109272

    Pulled By: yiwu-arbug

    fbshipit-source-id: e1bfb91346a59b7282a282b615002507e9d7c246

commit e2feac1324ef65437a8612e04a4f691233d0296a
Author: 奏之章 <zouzhizhang@qq.com>
Date:   Mon May 22 10:50:34 2017 +0800

    Fix for cl

commit 6fbe69c08231bfe479f2040673c4334369e480b7
Author: 奏之章 <zouzhizhang@qq.com>
Date:   Fri May 19 22:48:54 2017 +0800

    Merge facebook v5.3.3 -review

commit 3b7e46481300da09cf1398718fd1f14f16665e4e
Merge: efcb1bfb1 261da9029
Author: 奏之章 <zouzhizhang@qq.com>
Date:   Fri May 19 15:17:02 2017 +0800

    Merge facebook v5.3.3

commit efcb1bfb1ce060e92bd357ecad25c9fe2bded15c
Author: 奏之章 <mm304321141@gmail.com>
Date:   Tue May 9 16:48:56 2017 +0800

    Modify TeearkZipTableReaderTest

commit 1a9f07601b0fea5ee6c255cc7a8b2196e644bd72
Author: rockeet <rockeet@gmail.com>
Date:   Thu Apr 27 15:15:48 2017 +0800

    Fix with new func: TerarkZipMultiCFOptionsFromEnv()

commit 43b7ba679263fb72a56d4bddc9ef17725c8c0c94
Author: Lei Peng <rockeet@163.com>
Date:   Thu Apr 20 13:24:34 2017 +0800

    Fuck out rocksdb's brain damaged snappy & gflags detection

commit 5386da16f8662f08caa85cb3b7fa9582dea0016e
Author: rockeet <rockeet@gmail.com>
Date:   Mon Apr 17 14:46:39 2017 +0800

    mklib.sh: add ldb and db_bench to pkg

commit b990e46321a24891e73421b233e1dac7b1ea6fc1
Author: rockeet <rockeet@gmail.com>
Date:   Fri Apr 14 16:16:15 2017 +0800

    mklib.sh: uncomment make_lib 2 librocksdb_debug

commit 8829df97e03899d55f0748eb911791b2f5926b91
Author: rockeet <rockeet@gmail.com>
Date:   Fri Apr 14 16:11:08 2017 +0800

    use terark_zip_weak_function.h

commit 656cf19f604032c5dbec9e1ff349820043680abe
Merge: 41e886d41 3e2b51ce7
Author: 奏之章 <zouzhizhang@qq.com>
Date:   Fri Apr 14 15:46:06 2017 +0800

    Merge remote-tracking branch 'origin/master'

    # Conflicts:
    #	mklib.sh

commit 3e2b51ce77bcf529ac70b29f56a3d0e5dd54e46e
Author: rockeet <rockeet@gmail.com>
Date:   Fri Apr 14 14:50:41 2017 +0800

    Update README.md & mklib.sh

commit 41e886d4130504aad8f4c03840de080710b10eb5
Author: 奏之章 <mm304321141@gmail.com>
Date:   Fri Apr 14 14:51:44 2017 +0800

    Fix weak symbol declare

commit 883ac7bf2ae7cc379cc763f1af2078305e7ff198
Author: rockeet <rockeet@gmail.com>
Date:   Fri Apr 14 14:50:41 2017 +0800

    Update README.md & mklib.sh

commit 2d2ed52a65cf4e73f6e3df4b5c49dbfdf497c3a6
Author: rockeet <rockeet@163.com>
Date:   Thu Apr 13 21:17:32 2017 +0800

    tools/db_bench_tool.cc: unconditional set mmap_read = true when use_terarkzip_table

commit af84357cf1d645ca7cf74c5310e35025b55984da
Author: rockeet <rockeet@163.com>
Date:   Thu Apr 13 15:12:56 2017 +0800

    Makefile: bugfix

commit 261da90290c16a3645d06e4cee1cc4f7ac698f5f
Author: Islam AbdelRahman <tec@fb.com>
Date:   Wed Apr 12 11:36:12 2017 -0700

    bump version to 5.3.3

commit c0be8be0cffa92eb55f94cc4a88c3a2267ae101e
Author: Herman Lee <herman@fb.com>
Date:   Thu Mar 30 10:31:26 2017 -0700

    Cleanup of ThreadStatusUtil structures should use the DB's reference

    Summary:
    instead of thread_local

    The cleanup path for the rocksdb database might not have the
    thread_updater_local_cache_ pointer initialized because the thread
    executing the cleanup is likely not a rocksdb thread. This results in a
    memory leak detected by Valgrind. The cleanup code path should use the
    thread_status_updater pointer obtained from the DB object instead of a
    thread local one.
    Closes https://github.com/facebook/rocksdb/pull/2059

    Differential Revision: D4801611

    Pulled By: hermanlee

    fbshipit-source-id: 407d7de

commit 9af7ed4d9836789d5c8b5f83a8e01ad327e39fb1
Author: rockeet <rockeet@gmail.com>
Date:   Wed Apr 12 14:58:42 2017 +0800

    Makefile: BENCHTOOLOBJECTS: use librocksdb.so

commit 9d669ed9380b84c3d5c5777833bea3155fa2e58f
Author: rockeet <rockeet@gmail.com>
Date:   Tue Apr 11 17:31:16 2017 +0800

    db/external_sst_file_ingestion_job.cc: set ingestion_options_.allow_global_seqno = true for universal compaction - fix

commit addeb4249f6a5072d1d25018a2c24d9eb325da0f
Author: rockeet <rockeet@gmail.com>
Date:   Tue Apr 11 17:24:45 2017 +0800

    db/external_sst_file_ingestion_job.cc: set ingestion_options_.allow_global_seqno = true for universal compaction

commit 31093134dede6f52d6bc56632f44d4810b405a9c
Author: rockeet <rockeet@gmail.com>
Date:   Tue Apr 11 11:38:16 2017 +0800

    db_impl.cc: DBImpl::IngestExternalFile(): unconditional flush memtable on universal compaction

commit 7acb4324afda27efcb95ff5cd6a6d625199d3534
Author: rockeet <rockeet@gmail.com>
Date:   Mon Apr 10 21:10:11 2017 +0800

    db/external_sst_file_ingestion_job.cc: for universal compaction

commit aa6e71db41a9f340fb58e6cf9991525c760f79a9
Author: rockeet <rockeet@gmail.com>
Date:   Mon Apr 10 12:16:49 2017 +0800

    mklib.sh: minor fix

commit 30f52ec62a8eda1c0e039dd7da375af0c61901d3
Author: rockeet <rockeet@gmail.com>
Date:   Mon Apr 10 12:08:28 2017 +0800

    util/io_posix.cc: import fix for fallocate

    title: only FALLOC_FL_PUNCH_HOLE when ftruncate is buggy
    commit: 9e729390298c25adbd1cbf19948a5e4a882d6066
    rocksdb-issue: #2102

    description:
    Summary:
    In RocksDB, we sometimes preallocate the estimated space for a file to have better perf with fallocate (if supported). Usually it is a little bit bigger than the real resulting file size. At this time, we have to let the Filesystem reclaim the space not used.

    Ideally, calling ftruncate to truncate the file to its real size should be enough. HOWEVER, it isn't on tmpfs, which we witness in our case, with some buggy kernel version. ftruncate a file with preallocated space doesn't change number of the blocks used by the file, which means the space not used by the file is not returned to the filesystems. So in this case we need fallocate with FALLOC_FL_PUNCH_HOLE to explicitly reclaim the used blocks. It is a hack to cope with the kernel bug and usually we should not need it.
    Closes #2102

    Differential Revision: D4848934

    Pulled By: lightmark

    fbshipit-source-id: f1b40b5
    lightmark committed with facebook-github-bot 3 days ago

commit 5c88aa31cc7498b2fb95ef575166654fb24756d0
Author: rockeet <rockeet@gmail.com>
Date:   Fri Apr 7 15:08:45 2017 +0800

    Add note: needs include path terark-zip-rocksdb/src

commit 4fb65f9ea7696cf9793e90b0682ee8aa5f582b1d
Author: Islam AbdelRahman <tec@fb.com>
Date:   Thu Apr 6 17:04:23 2017 -0700

    Bump version to 5.3.2

commit ee33e299a0694023429be52e1387f9b73f27afbb
Author: Islam AbdelRahman <tec@fb.com>
Date:   Thu Mar 16 12:06:04 2017 -0700

    Support SstFileManager::SetDeleteRateBytesPerSecond()

    Summary:
    Update DeleteScheduler component to support changing delete rate in runtime by introducing
    SstFileManager::SetDeleteRateBytesPerSecond()
    Closes https://github.com/facebook/rocksdb/pull/1994

    Differential Revision: D4719906

    Pulled By: IslamAbdelRahman

    fbshipit-source-id: e6b8d9e

commit 5e0bddf8378d94197137e0680c992fbdb3d844ef
Author: Andrew Kryczka <andrewkr@fb.com>
Date:   Wed Apr 5 14:13:25 2017 -0700

    bump patch version

commit 4f0ef721d7cd8b2be4859dd96ea75c81f26e1443
Author: Andrew Kryczka <andrewkr@fb.com>
Date:   Wed Apr 5 14:11:33 2017 -0700

    revert remove fallocate punch hole

commit 491fa696fa8d2676b1f424b06734d7a823d6ea79
Author: Mikhail Antonov <antonov@apache.org>
Date:   Wed Mar 29 17:13:43 2017 -0700

    Added SstFileWriter construtor without explicit comparator to JNI api

    Summary:
    Adding API missing after https://github.com/facebook/rocksdb/commit/1ffbdfd9a7637b6517053842386d71df2cd00d9b#diff-b94146418eed4a9c1bf324041b95b279.

    adamretter  IslamAbdelRahman

    Tested locally.
    Closes https://github.com/facebook/rocksdb/pull/2028

    Differential Revision: D4762817

    Pulled By: IslamAbdelRahman

    fbshipit-source-id: 833f478

commit f966f8c7cc7839007893f7902030cbdecdde11e5
Author: rockeet <rockeet@gmail.com>
Date:   Sat Apr 1 17:27:04 2017 +0800

    git checkout 21d8c3 include/rocksdb/db.h, and minor fix: remove #include "port/likely.h"

commit cbe98c749a438a0c94414dcd5d9fe3f2c680ed60
Author: rockeet <rockeet@gmail.com>
Date:   Sat Apr 1 15:45:07 2017 +0800

    mklib.sh: minor fix

commit ae563ec38b0c6d44fa5afec539923791f0ee12a6
Author: rockeet <rockeet@gmail.com>
Date:   Sat Apr 1 15:31:31 2017 +0800

    Makefile: minor fix

commit cfa1337b5b0f4c4196e862e98056e2f343701011
Author: rockeet <rockeet@gmail.com>
Date:   Sat Apr 1 14:08:57 2017 +0800

    for: #include <table/terark_zip_weak_function.h>

commit cfcce7b0c6c42d0b1899c6bdc808035b6197c905
Author: 奏之章 <mm304321141@gmail.com>
Date:   Fri Mar 31 16:33:48 2017 +0800

    Fix for IngestExternalFile with allow_mmap_reads

commit dc51c0659d8e3d5eaca886779c2506c5ad0bfee8
Author: rockeet <rockeet@gmail.com>
Date:   Fri Mar 31 11:34:15 2017 +0800

    Fix rocksdb member init order

commit 41a36277ef006c5c4e8a680baf7dfe0e1e3cdb19
Merge: 4a52266c9 d52f334cb
Author: rockeet <rockeet@gmail.com>
Date:   Fri Mar 31 11:23:15 2017 +0800

    git merge d52f334cbd4bceee23f13470f137220c8a75686b : rocksdb refered by myrocks

commit 4fa68fb3f26ba6b62823be003a956c41db170bc3
Author: Aaron Gao <gzh@fb.com>
Date:   Mon Mar 13 11:35:50 2017 -0700

    update history.md for fixing the bug that skips keys

    Summary: Closes https://github.com/facebook/rocksdb/pull/1986

    Differential Revision: D4699152

    Pulled By: siying

    fbshipit-source-id: b18c32c

commit 76979d84bfad26421ed23203400db1eadee21d90
Author: Aaron Gao <gzh@fb.com>
Date:   Tue Mar 28 15:47:54 2017 -0700

    delete fallocate with punch_hole

    Summary:
    As discuss in this thread:
    https://www.facebook.com/groups/rocksdb.dev/permalink/1218043868294125/

    We remove fallocate with FALLOC_FL_PUNCH_HOLE because the recent bug on xfs in kernel 4.x+ that align file size to page size even with FALLOC_FL_KEEP_SIZE | FALLOC_FL_PUNCH_HOLE.
    Closes https://github.com/facebook/rocksdb/pull/2038

    Differential Revision: D4779974

    Pulled By: siying

    fbshipit-source-id: 5f54625

commit 4a52266c9dcc7409f9688711649d7ac0415ed127
Merge: 7fb825955 bae811fca
Author: rockeet <rockeet@gmail.com>
Date:   Thu Mar 30 21:04:42 2017 +0800

    git merge rocksdb-official/5.3.fb

commit 7fb825955293d61628a881538661483e7e4935a3
Author: 奏之章 <mm304321141@gmail.com>
Date:   Thu Mar 30 18:32:55 2017 +0800

    Fix sst_dump

commit bae811fca0190c5c2ee273df4c07bbc04176b165
Author: Siying Dong <siying.d@fb.com>
Date:   Wed Mar 29 11:42:56 2017 -0700

    Expose the stalling information through DB::GetProperty()

    Summary:
    Add two DB properties: rocksdb.actual_delayed_write_rate and rocksdb.is_write_stooped, for people to know whether current writes are being throttled.
    Closes https://github.com/facebook/rocksdb/pull/2043

    Differential Revision: D4782975

    Pulled By: siying

    fbshipit-source-id: 6b2f5cf

commit 052dee06de7c695ca425e7e6cfd1c1ab173c39ee
Author: 奏之章 <mm304321141@gmail.com>
Date:   Wed Mar 29 21:32:57 2017 +0800

    Fix sst_dump

commit 3e83ccffc2383e559ac40345f1123494a570d0d9
Author: rockeet <rockeet@gmail.com>
Date:   Wed Mar 29 21:30:10 2017 +0800

    fix typo

commit fae4f87891f95dace2b71096f85491efe08e08d9
Author: rockeet <rockeet@gmail.com>
Date:   Wed Mar 29 21:27:31 2017 +0800

    Fix potential bugs notified by eclipse - 2

commit e33dd891e550ddeea9784c868d9a4b5cd1a8ba03
Author: rockeet <rockeet@gmail.com>
Date:   Wed Mar 29 21:21:32 2017 +0800

    Fix potential bugs notified by eclipse

commit 72e78c32c435b42d284b2d5bad5aa99c76301c94
Author: 奏之章 <mm304321141@gmail.com>
Date:   Wed Mar 29 21:03:48 2017 +0800

    Fix sst_dump

commit e532105268e36bf99245328261572110b1d3d2f3
Author: 奏之章 <mm304321141@gmail.com>
Date:   Wed Mar 29 17:41:42 2017 +0800

    Fix sst_dump

commit b3deb97767d7dc52744e35c059c916b8a5a05c83
Author: ZouZhiZhang <mm304321141@gmail.com>
Date:   Wed Mar 29 14:52:13 2017 +0800

    Fix for tests

commit f89b93ca58b13ecd0560cc3a561ea6a30316f00a
Author: 奏之章 <mm304321141@gmail.com>
Date:   Wed Mar 29 12:24:54 2017 +0800

    disableSecondPassIter

commit 727c652288a10ac1cfbc38001ae84de2994ba7bd
Author: ZouZhiZhang <mm304321141@gmail.com>
Date:   Wed Mar 29 11:41:07 2017 +0800

    Fix Makefile

commit ec27c4f1d3ba972f0d8acaf5cf53e22e41a771af
Author: 奏之章 <mm304321141@gmail.com>
Date:   Wed Mar 29 10:48:43 2017 +0800

    Fix RangeDelete bugs

commit b900f6e197757ff34364d50a361a9d37bca66c6e
Author: Andrew Kryczka <andrewkr@fb.com>
Date:   Thu Mar 23 18:27:51 2017 -0700

    fix a header include

commit 84231bf680f3361a88666207ea6f6f74ee1ef500
Author: 奏之章 <mm304321141@gmail.com>
Date:   Thu Mar 23 15:32:40 2017 +0800

    Add virtual func IsDeleteRangeSupported

commit bb14ff7c788cd4ff1ca4d8196531a6b1248726d9
Author: Siying Dong <siying.d@fb.com>
Date:   Wed Mar 22 11:13:55 2017 -0700

    HISTORY.md for log_size_for_flush in CreateCheckpoint()

    Summary: Closes https://github.com/facebook/rocksdb/pull/2021

    Differential Revision: D4755324

    Pulled By: siying

    fbshipit-source-id: c8d7955

commit 47177be34ef3e31eb287a62fea24208c907dde49
Author: Siying Dong <siying.d@fb.com>
Date:   Tue Mar 21 17:53:21 2017 -0700

    Allow checkpointing without flushing

    Summary:
    Add a parameter to Checkpoint::CreateCheckpoint() so that flush can be skipped if total log file size is within a threshold.
    Closes https://github.com/facebook/rocksdb/pull/1993

    Differential Revision: D4719842

    Pulled By: siying

    fbshipit-source-id: 4f9d9e1

commit e54e5182990bed48245b2a4cdc4c7593f54d6197
Author: rockeet <rockeet@gmail.com>
Date:   Wed Mar 15 15:08:41 2017 +0800

    util/file_reader_writer.h: RandomAccessFileReader: bug fix for movecons & move assign

commit 53499b682c9d8fb4e61b35a8eedc2c1303959e9a
Author: rockeet <rockeet@gmail.com>
Date:   Tue Mar 14 20:36:41 2017 +0800

    compaction_job.cc: remove range_del_agg2

commit d0d8228986508492b3ae48a5106a1acbb08d23a1
Author: rockeet <rockeet@gmail.com>
Date:   Tue Mar 14 19:17:25 2017 +0800

    compaction_job.cc: make dup object for second pass iterator

commit a2428dbaff12f8eeaa70e56586406b9048335f7c
Author: rockeet <rockeet@gmail.com>
Date:   Tue Mar 14 17:57:30 2017 +0800

    remove anonymous namespace for CompactionIteratorToInternalIterator

commit 0e5aeb9f761b5617f24f63a82602c7913e3c5ce9
Author: rockeet <rockeet@gmail.com>
Date:   Tue Mar 14 14:21:31 2017 +0800

    db/builder.cc: minor fix

commit 4ccee3ec1c440b14ff7d15c3609f74a2b8eeb171
Author: rockeet <rockeet@gmail.com>
Date:   Tue Mar 14 14:06:24 2017 +0800

    db/compaction_job.cc: minor fix

commit b59de496cbb094a6003df3cc20c6488afadffc85
Author: 奏之章 <zouzhizhang@qq.com>
Date:   Mon Mar 13 16:59:42 2017 +0800

    Rename terocks to terarkdb

commit 93989b0ae8fadb2a561b2af4c78d2385c2b68af6
Author: Andrew Kryczka <andrewkr@fb.com>
Date:   Fri Mar 10 10:46:55 2017 -0800

    fix histogram max typecast

commit 344c82c2fd4d0ea10ecf79ff4e51a9a7fecf0ff3
Author: 奏之章 <mm304321141@gmail.com>
Date:   Fri Mar 10 10:35:50 2017 +0800

    Add _MSC_VER for VC cl

commit 50d191da4561c12479ea579fe893f88bd171c8f2
Author: rockeet <rockeet@gmail.com>
Date:   Thu Mar 9 20:56:57 2017 +0800

    tools/ldb_cmd.cc: fix TerarkZipAutoConfigForOnlineDB() declaration

commit 467568f02dd42d1e4028284ecbf5cfd1de5235bf
Author: rockeet <rockeet@gmail.com>
Date:   Thu Mar 9 20:41:31 2017 +0800

    Makefile: Minor fix

commit 2f3d31b3e434315c115440f990f3a0038f8b4e23
Merge: 6b7bbc286 e5fd8bdb8
Author: rockeet <rockeet@gmail.com>
Date:   Mon Feb 20 14:44:13 2017 +0800

    git merge rocksdb-official/5.2.fb

commit 6b7bbc286e869e0bf82f9b870beb5b25d67a595b
Author: rockeet <rockeet@gmail.com>
Date:   Mon Feb 20 11:15:32 2017 +0800

    Bug fix

commit 83b988a341823aaab9356cd5b04a26a51105bf58
Author: rockeet <rockeet@gmail.com>
Date:   Wed Feb 15 18:12:25 2017 +0800

    Update TeRocksDB.md

commit bd576a483f949986ba386249c561f9694e93af55
Author: rockeet <rockeet@gmail.com>
Date:   Wed Feb 15 18:08:42 2017 +0800

    remove EnvOptions::use_mmap_populate

commit 20ae60279c69b07965fa42ec4d86fb9ee90f974a
Author: rockeet <rockeet@gmail.com>
Date:   Wed Feb 15 18:08:06 2017 +0800

    git add TeRocksDB.md

commit f…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants