Fix segmentation fault caused by #1961 #2029
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Fixes facebook#1961 which causes a segfault when filter_policy is nullptr and both pin_l0_filter_and_index_blocks_in_cache/cache_index_and_filter_blocks are set. Test Plan: TEST_TMPDIR=/data/rate_limit_bench/ ./db_bench -benchmarks=fillrandom -pin_l0_filter_and_index_blocks_in_cache=true -cache_index_and_filter_blocks=true Reviewers: Subscribers: Tasks: Tags: Blame Revision:
|
@maysamyabandeh has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
mikhail-antonov
approved these changes
Mar 23, 2017
siying
approved these changes
Mar 24, 2017
|
@ajkr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
1 similar comment
|
@ajkr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes #1961 which causes a segfault when filter_policy is nullptr and both
pin_l0_filter_and_index_blocks_in_cache/cache_index_and_filter_blocks
are set.
Test Plan:
TEST_TMPDIR=/data/rate_limit_bench/ ./db_bench -benchmarks=fillrandom
-pin_l0_filter_and_index_blocks_in_cache=true
-cache_index_and_filter_blocks=true
Reviewers:
Subscribers:
Tasks:
Tags:
Blame Revision: