Add release notes for PinnableSlice #2037
Conversation
maysamyabandeh
force-pushed
the
pinnableslice-release-note
branch
from
3cebbfb
to
c41870f
Compare
|
@maysamyabandeh updated the pull request - view changes |
maysamyabandeh
force-pushed
the
pinnableslice-release-note
branch
from
c41870f
to
66174bc
Compare
|
@maysamyabandeh updated the pull request - view changes |
HISTORY.md
Outdated
| @@ -2,6 +2,9 @@ | |||
| ## Unreleased | |||
| ### Public API Change | |||
| * Support dynamically change `stats_dump_period_sec` option via SetDBOptions(). | |||
| * DB::Get in place of std::string accepts PinnableSlice, which avoids the extra memcpy of value to std::string in most of cases. | |||
| ** PinnableSlice releases the pinned resources that contain the value when it is destructed or when ::Reset() is called on it. | |||
There was a problem hiding this comment.
I think we should not use the subitems like using **
I think it won't be readable when we do the release https://github.com/maysamyabandeh/rocksdb/blob/66174bc720a0e213f74f399cebc56bc247856d0f/HISTORY.md
HISTORY.md
Outdated
| @@ -2,6 +2,9 @@ | |||
| ## Unreleased | |||
| ### Public API Change | |||
| * Support dynamically change `stats_dump_period_sec` option via SetDBOptions(). | |||
| * DB::Get in place of std::string accepts PinnableSlice, which avoids the extra memcpy of value to std::string in most of cases. | |||
| * PinnableSlice releases the pinned resources that contain the value when it is destructed or when ::Reset() is called on it. | |||
| * The old API that accepts std::string is deprecated | |||
There was a problem hiding this comment.
Can you clarify what does "deprecated" mean? In this code base, we previously use "deprecated" as something already not supported. It's arguable whether we are using this word in a correct way, but I don't want people to get confused.
There was a problem hiding this comment.
Sure. Will remove the term deprecated.
|
@maysamyabandeh updated the pull request - view changes |
|
@maysamyabandeh updated the pull request - view changes |
|
@maysamyabandeh has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
maysamyabandeh
force-pushed
the
pinnableslice-release-note
branch
from
68e9cc7
to
ea44aff
Compare
|
@maysamyabandeh updated the pull request - view changes - changes since last import |
|
@maysamyabandeh has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
No description provided.