Added naming of backup engine threads #2053
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In this case the background worker thread is actually thread 19. Thread 1 is the user thread who's calling CreateNewBackup, we don't want to rename this one. |
|
These are the threads we want to rename: https://github.com/facebook/rocksdb/blob/master/utilities/backupable/backupable_db.cc#L649-L660 |
|
@s-sharan updated the pull request - view changes |
|
Fixed it
|
ajkr
reviewed
Mar 29, 2017
| @@ -647,6 +647,7 @@ Status BackupEngineImpl::Initialize() { | |||
| // background | |||
| for (int t = 0; t < options_.max_background_operations; t++) { | |||
| threads_.emplace_back([this]() { | |||
| pthread_setname_np(pthread_self(), "backup_engine"); | |||
There was a problem hiding this comment.
I think it's glibc-specific, maybe conditionally compile this line using #ifdef OS_LINUX
added 2 commits
March 29, 2017 12:13
|
@s-sharan updated the pull request - view changes |
ajkr
approved these changes
Mar 29, 2017
|
@ajkr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the naming of backup engine threads from "ldb" to "backup_engine"
Test Plan: