-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move memtable related files into memtable directory #2087
Conversation
@yiwu-arbug has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will we want to remove memtable->db dependencies in the future?
@ajkr Good point! Will work on it. |
The list of memtable->db dependencies:
memtable.h contain too many dependencies from db. Shall we move it back to db directory? |
@yiwu-arbug yes, maybe move it back. Just leave the skiplist rep. |
@siying cool. |
Summary: Move memtable related files into memtable directory. Test Plan: run existing tests.
@yiwu-arbug updated the pull request - view changes - changes since last import |
Will land after windows build pass. |
@yiwu-arbug has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Summary: Move memtable related files into memtable directory. Closes facebook#2087 Differential Revision: D4829242 Pulled By: yiwu-arbug fbshipit-source-id: ca70ab6
Summary:
Move memtable related files into memtable directory.
Test Plan:
run existing tests.