Fix BYTES_WRITTEN accounting #2133
Conversation
BYTES_WRITTEN accounting doesn't work with disabled WAL. For example, this is what we get in the LOG: ``` Cumulative writes: 9794K writes, 228M keys, 9794K commit groups, 1.0 writes per commit group, ingest: 0.00 GB, 0.00 MB/s ``` WAL bytes are tracked in a different statistic: https://github.com/facebook/rocksdb/blob/master/db/internal_stats.h#L105. BYTES_WRITTEN should count all the writes.
|
Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours has expired. Before we can review or merge your code, we need you to email cla@fb.com with your details so we can update your status. |
|
Trying to sign CLA on https://code.facebook.com/cla, I get "This content is no longer available" when I click "I agree" :( |
|
Thank you for the fix, @igorcanadi ! Let me check how to fix the CLA problem. |
|
@igorcanadi You need to email cla@fb.com The CLA form does not work for former employee :( |
Will do, thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
@yiwu-arbug has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
BYTES_WRITTEN accounting doesn't work with disabled WAL. For example, this is what we
get in the LOG:
WAL bytes are tracked in a different statistic:
https://github.com/facebook/rocksdb/blob/master/db/internal_stats.h#L105.
BYTES_WRITTEN should count all the writes.