AIX and Solaris Sparc Support #2194
Conversation
|
@siying has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@koldat thank you for doing this extra thing. Sorry about the trouble. Our internal system is migrating, so this is one time thing. Next time it should be fine. |
|
I'll merge as soon as our internal tests pass. |
|
@siying has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
The calls to GetUnaligned / PutUnaligned in options_helper don't make any sense to me because passing the uint64_t* for a field like max_bytes_for_level_base through void* doesn't change its alignment. "Conversion of any pointer to pointer to void and back to pointer to the original (or more cv-qualified) type preserves its original value." |
Replacement of #2147
The change was squashed due to a lot of conflicts.