Fix data races caught by tsan #2339
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sagar0 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
siying
reviewed
May 22, 2017
| std::atomic<uint64_t> cache_hits_{0}; | ||
| std::atomic<uint64_t> cache_misses_{0}; | ||
| std::atomic<uint64_t> cache_errors_{0}; | ||
| std::atomic<uint64_t> insert_dropped_{0}; |
There was a problem hiding this comment.
Do we need to change in where the counters are incremented to be relaxed order?
There was a problem hiding this comment.
I think you are right; I did not realize that the default memory order could impact the performance here. I'll read up a bit on the right memory_order to use here, and make the right change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the tsan build failures in:
Test plan:
COMPILE_WITH_TSAN=1 make check