Fix db_bench build break with blob db #2372
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yiwu-arbug has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
anirbanr-fb
approved these changes
May 25, 2017
|
@yiwu-arbug has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
siying
approved these changes
May 25, 2017
|
@siying I don't think I put blob into db_stress. If so we should remove it. |
yiwu-arbug
pushed a commit
that referenced
this pull request
May 30, 2017
Summary: Lite build does not recognize FLAGS_use_blob_db. Fixing it. Closes #2372 Reviewed By: anirbanr-fb Differential Revision: D5130773 Pulled By: yiwu-arbug fbshipit-source-id: 43131d9d0be5811f2129af562be72cca26369cb3
yiwu-arbug
pushed a commit
that referenced
this pull request
Jul 17, 2017
Summary: Lite build does not recognize FLAGS_use_blob_db. Fixing it. Closes #2372 Reviewed By: anirbanr-fb Differential Revision: D5130773 Pulled By: yiwu-arbug fbshipit-source-id: 43131d9d0be5811f2129af562be72cca26369cb3
siying
reviewed
Jan 9, 2018
| @@ -3472,8 +3483,10 @@ void VerifyDBFromDB(std::string& truth_db_name) { | |||
| } | |||
| } | |||
| } | |||
| if (!FLAGS_use_blob_db) { | |||
| if (!use_blob_db_) { | |||
| #ifndef ROCKSDB_LITE | |||
There was a problem hiding this comment.
This seems to be a bug to me. Now db_bench doesn't insert anything with LITE.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Lite build does not recognize FLAGS_use_blob_db. Fixing it.
Test Plan:
OPT=-DROCKSDB_LITE make all