Java APIs for put, merge and delete in file ingestion #2392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sagar0 updated the pull request - view changes |
|
@sagar0 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
sagar0
changed the title
adamretter
requested changes
Jun 2, 2017
| @@ -25,12 +25,38 @@ public void open(final String filePath) throws RocksDBException { | |||
| open(nativeHandle_, filePath); | |||
| } | |||
|
|
|||
| @Deprecated | |||
There was a problem hiding this comment.
Can you add the javadoc please? Including @deprecated annotation in the javadoc itself?
sagar0
force-pushed
the
java-new-file-ingestion-apis
branch
from
217fc2d
to
7efdbca
Compare
|
@sagar0 updated the pull request - view changes - changes since last import |
|
Travis build/test failures are unrelated to this code. |
adamretter
approved these changes
Jun 8, 2017
|
@sagar0 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
yiwu-arbug
pushed a commit
that referenced
this pull request
Jun 9, 2017
Summary: Adding SSTFileWriter's newly introduced put, merge and delete apis to the Java api. The C++ APIs were first introduced in #2361. Add is deprecated in favor of Put. Merge is especially needed to support streaming for Cassandra-on-RocksDB work in https://issues.apache.org/jira/browse/CASSANDRA-13476. Closes #2392 Differential Revision: D5165091 Pulled By: sagar0 fbshipit-source-id: 6f0ad396a7cbd2e27ca63e702584784dd72acaab
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding SSTFileWriter's newly introduced put, merge and delete apis to the Java api. The C++ APIs were first introduced in #2361.
Add is deprecated in favor of Put.
Merge is especially needed to support streaming for Cassandra-on-RocksDB work in https://issues.apache.org/jira/browse/CASSANDRA-13476.
Test Plan:
Unit tests:
make jtest