Update java/rocksjni.pom #2610
Closed
Update java/rocksjni.pom #2610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sagar0
reviewed
Jul 18, 2017
java/rocksjni.pom
Outdated
| @@ -19,6 +19,11 @@ | |||
| <url>http://www.apache.org/licenses/LICENSE-2.0.html</url> | |||
| <distribution>repo</distribution> | |||
| </license> | |||
| <license> | |||
| <name>GNU General Public License, version 2</name> | |||
| <url>http://opensource.org/licenses/gpl-2.0</url> | |||
There was a problem hiding this comment.
Wondering if the URL should actually link to https://www.gnu.org/licenses/old-licenses/gpl-2.0.en.html , or some link directly from gnu.org ?
There was a problem hiding this comment.
The one we are using is https://www.gnu.org/licenses/gpl-2.0.txt
Maybe I should put that one.
There was a problem hiding this comment.
There was a problem hiding this comment.
yeah, google search shows those links from gnu.org to be more authentic and lot more used. So, either one of those should be good.
|
@siying updated the pull request - view changes |
sagar0
approved these changes
Jul 18, 2017
|
@siying has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@siying looks good to me. |
yiwu-arbug
pushed a commit
that referenced
this pull request
Jul 21, 2017
Summary: Closes #2610 Differential Revision: D5445705 Pulled By: siying fbshipit-source-id: d5f97ffdf5bc18b853c3a106755aca96a650e428
IslamAbdelRahman
pushed a commit
that referenced
this pull request
Jul 26, 2017
Summary: Closes #2610 Differential Revision: D5445705 Pulled By: siying fbshipit-source-id: d5f97ffdf5bc18b853c3a106755aca96a650e428
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.