Makefile: fix for GCC 7+ and clang 4+ #2681
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Makefile
Outdated
| @@ -255,6 +255,19 @@ default: all | |||
| WARNING_FLAGS = -W -Wextra -Wall -Wsign-compare -Wshadow \ | |||
| -Wno-unused-parameter | |||
|
|
|||
| CCVERSION = $(shell cc -dumpversion) | |||
There was a problem hiding this comment.
cc -> $CXX
or ${CXX:-cc} though I have doubts that cc is right.
|
@choleraehyq updated the pull request - view changes |
Signed-off-by: Cholerae Hu <huyingqian@pingcap.com>
|
@choleraehyq updated the pull request - view changes |
|
Is it possible to fix the code rather than suppress the warning? |
|
@siying this should enable compiler support for allocating over-aligned types. We still don't use |
Makefile
Outdated
|
|
||
| ifeq ($(CCNAME), clang) | ||
| ifeq ($(CCVERSION), 4*) | ||
| WARNING_FLAGS += -faligned-new |
There was a problem hiding this comment.
Can you put it in CXX_FLAGS instead as it's not really a warning flag?
Signed-off-by: Cholerae Hu <huyingqian@pingcap.com>
This reverts commit c80455b.
Signed-off-by: Cholerae Hu <huyingqian@pingcap.com>
|
@choleraehyq updated the pull request - view changes |
|
@choleraehyq updated the pull request - view changes |
|
Sorry our tools won't let me pull it unless the CLA is signed (https://code.facebook.com/cla). |
|
Signed! @ajkr |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
@ajkr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
@maysamyabandeh @IslamAbdelRahman PTAL
Fix #2672
Signed-off-by: Cholerae Hu huyingqian@pingcap.com