Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix inclusive-exclusiveness of histogram ToString #2817

Closed
wants to merge 2 commits into from
Closed

fix inclusive-exclusiveness of histogram ToString #2817

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7547192
fix inclusive-exclusiveness of histogram ToString
ajkr Aug 31, 2017
a126ec7
improve test case comment
ajkr Sep 1, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion monitoring/histogram_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,11 @@ TEST_F(HistogramTest, BasicOperation) {

TEST_F(HistogramTest, BoundaryValue) {
HistogramImpl histogram;
// both should be in [0, 1], never (1, 2].
// - both should be in [0, 1] bucket because we place values on bucket
// boundaries in the lower bucket.
// - all points are in [0, 1] bucket, so p50 will be 0.5
// - the test cannot be written with a single point since histogram won't
// report percentiles lower than the min or greater than the max.
histogram.Add(0);
histogram.Add(1);

Expand Down