Fix naming in InternalKey #2868
Conversation
|
@axxufb has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
One suggestion is to change the comment on line 412 in db/version_set.cc from "Find the earliest possible internal key for smallest_user_key" to "Find the leftmost possible internal key for smallest_user_key" as the earliest internal key not be the min possible unless it is the only one for that user key. |
db/dbformat.h
Outdated
| AppendInternalKey( | ||
| &rep_, ParsedInternalKey(_user_key, 0, static_cast<ValueType>(0))); | ||
| AppendInternalKey(&rep_, ParsedInternalKey(_user_key, kMaxSequenceNumber, | ||
| kValueTypeForSeek)); |
There was a problem hiding this comment.
maybe run make format to fix the whitespace
There was a problem hiding this comment.
"make format" replies on internal library, so it can't be used outside the company.
db/version_set.cc
Outdated
| @@ -411,7 +411,7 @@ bool SomeFileOverlapsRange( | |||
| if (smallest_user_key != nullptr) { | |||
| // Find the earliest possible internal key for smallest_user_key | |||
axxufb
force-pushed
the
internalkey_name_fix
branch
from
7b23faa
to
7f26a80
Compare
|
@axxufb updated the pull request - view changes - changes since last import |
|
@axxufb has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
1 similar comment
|
@axxufb has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Task: T21624617
Test Plan: