Fix WriteBatchWithIndex::GetFromBatchAndDB not allowing StackableDB #2881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yiwu-arbug has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
maysamyabandeh
approved these changes
Sep 13, 2017
|
@yiwu-arbug has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
to facebook/mysql-5.6
that referenced
this pull request
Sep 14, 2017
Summary: Bump rocksdb to include the fix for rocksdb.trx_info_rpl The bug was introduced in: facebook/rocksdb#2850 Fixed in: facebook/rocksdb#2881 update-submodule: rocksdb Reviewed By: lth Differential Revision: D5834658 fbshipit-source-id: d1551bf
spetrunia
added a commit
to MariaDB/mergetrees
that referenced
this pull request
Sep 15, 2017
commit 184a4a2d82f4f6f3cbcb1015bcdb32bebe73315c
Author: Abhinav Sharma <abhinavsharma@fb.com>
Date: Thu Sep 14 11:40:08 2017 -0700
Bump rocksdb submodule
Summary:
Bump rocksdb to include the fix for rocksdb.trx_info_rpl
The bug was introduced in: facebook/rocksdb#2850
Fixed in: facebook/rocksdb#2881
update-submodule: rocksdb
Reviewed By: lth
Differential Revision: D5834658
fbshipit-source-id: d1551bf
george-lorch
pushed a commit
to george-lorch/percona-server
that referenced
this pull request
Oct 26, 2017
Upstream commit ID : fb-mysql-5.6.35/184a4a2d82f4f6f3cbcb1015bcdb32bebe73315c Summary: Bump rocksdb to include the fix for rocksdb.trx_info_rpl The bug was introduced in: facebook/rocksdb#2850 Fixed in: facebook/rocksdb#2881 update-submodule: rocksdb Reviewed By: lth Differential Revision: D5834658 fbshipit-source-id: d1551bf
george-lorch
pushed a commit
to george-lorch/percona-server
that referenced
this pull request
Oct 26, 2017
Upstream commit ID : fb-mysql-5.6.35/184a4a2d82f4f6f3cbcb1015bcdb32bebe73315c Summary: Bump rocksdb to include the fix for rocksdb.trx_info_rpl The bug was introduced in: facebook/rocksdb#2850 Fixed in: facebook/rocksdb#2881 update-submodule: rocksdb Reviewed By: lth Differential Revision: D5834658 fbshipit-source-id: d1551bf
george-lorch
pushed a commit
to george-lorch/percona-server
that referenced
this pull request
Oct 27, 2017
Upstream commit ID : fb-mysql-5.6.35/184a4a2d82f4f6f3cbcb1015bcdb32bebe73315c Summary: Bump rocksdb to include the fix for rocksdb.trx_info_rpl The bug was introduced in: facebook/rocksdb#2850 Fixed in: facebook/rocksdb#2881 update-submodule: rocksdb Reviewed By: lth Differential Revision: D5834658 fbshipit-source-id: d1551bf
george-lorch
pushed a commit
to george-lorch/percona-server
that referenced
this pull request
Oct 27, 2017
Upstream commit ID : fb-mysql-5.6.35/184a4a2d82f4f6f3cbcb1015bcdb32bebe73315c Summary: Bump rocksdb to include the fix for rocksdb.trx_info_rpl The bug was introduced in: facebook/rocksdb#2850 Fixed in: facebook/rocksdb#2881 update-submodule: rocksdb Reviewed By: lth Differential Revision: D5834658 fbshipit-source-id: d1551bf
george-lorch
pushed a commit
to george-lorch/percona-server
that referenced
this pull request
Oct 30, 2017
Upstream commit ID : fb-mysql-5.6.35/184a4a2d82f4f6f3cbcb1015bcdb32bebe73315c Summary: Bump rocksdb to include the fix for rocksdb.trx_info_rpl The bug was introduced in: facebook/rocksdb#2850 Fixed in: facebook/rocksdb#2881 update-submodule: rocksdb Reviewed By: lth Differential Revision: D5834658 fbshipit-source-id: d1551bf
george-lorch
pushed a commit
to george-lorch/percona-server
that referenced
this pull request
Oct 31, 2017
Upstream commit ID : fb-mysql-5.6.35/184a4a2d82f4f6f3cbcb1015bcdb32bebe73315c Summary: Bump rocksdb to include the fix for rocksdb.trx_info_rpl The bug was introduced in: facebook/rocksdb#2850 Fixed in: facebook/rocksdb#2881 update-submodule: rocksdb Reviewed By: lth Differential Revision: D5834658 fbshipit-source-id: d1551bf
george-lorch
pushed a commit
to george-lorch/percona-server
that referenced
this pull request
Oct 31, 2017
Upstream commit ID : fb-mysql-5.6.35/184a4a2d82f4f6f3cbcb1015bcdb32bebe73315c Summary: Bump rocksdb to include the fix for rocksdb.trx_info_rpl The bug was introduced in: facebook/rocksdb#2850 Fixed in: facebook/rocksdb#2881 update-submodule: rocksdb Reviewed By: lth Differential Revision: D5834658 fbshipit-source-id: d1551bf
george-lorch
pushed a commit
to george-lorch/percona-server
that referenced
this pull request
Nov 1, 2017
Upstream commit ID : fb-mysql-5.6.35/184a4a2d82f4f6f3cbcb1015bcdb32bebe73315c Summary: Bump rocksdb to include the fix for rocksdb.trx_info_rpl The bug was introduced in: facebook/rocksdb#2850 Fixed in: facebook/rocksdb#2881 update-submodule: rocksdb Reviewed By: lth Differential Revision: D5834658 fbshipit-source-id: d1551bf
facebook-github-bot
pushed a commit
to facebook/mysql-5.6
that referenced
this pull request
Dec 23, 2019
Summary: Bump rocksdb to include the fix for rocksdb.trx_info_rpl The bug was introduced in: facebook/rocksdb#2850 Fixed in: facebook/rocksdb#2881 update-submodule: rocksdb Reviewed By: lth Differential Revision: D5834658 fbshipit-source-id: f731b47
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Aug 12, 2020
Summary: Bump rocksdb to include the fix for rocksdb.trx_info_rpl The bug was introduced in: facebook/rocksdb#2850 Fixed in: facebook/rocksdb#2881 update-submodule: rocksdb Reviewed By: lth Differential Revision: D5834658 fbshipit-source-id: f731b47
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Sep 9, 2020
Summary: Bump rocksdb to include the fix for rocksdb.trx_info_rpl The bug was introduced in: facebook/rocksdb#2850 Fixed in: facebook/rocksdb#2881 update-submodule: rocksdb Reviewed By: lth Differential Revision: D5834658 fbshipit-source-id: f731b47
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Sep 16, 2020
Summary: Bump rocksdb to include the fix for rocksdb.trx_info_rpl The bug was introduced in: facebook/rocksdb#2850 Fixed in: facebook/rocksdb#2881 update-submodule: rocksdb Reviewed By: lth Differential Revision: D5834658 fbshipit-source-id: f731b47
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Oct 5, 2020
Summary: Bump rocksdb to include the fix for rocksdb.trx_info_rpl The bug was introduced in: facebook/rocksdb#2850 Fixed in: facebook/rocksdb#2881 update-submodule: rocksdb Reviewed By: lth Differential Revision: D5834658 fbshipit-source-id: f731b47
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Nov 11, 2020
Summary: Bump rocksdb to include the fix for rocksdb.trx_info_rpl The bug was introduced in: facebook/rocksdb#2850 Fixed in: facebook/rocksdb#2881 update-submodule: rocksdb Reviewed By: lth Differential Revision: D5834658 fbshipit-source-id: f731b47
facebook-github-bot
pushed a commit
to facebook/mysql-5.6
that referenced
this pull request
Mar 8, 2021
Summary: Bump rocksdb to include the fix for rocksdb.trx_info_rpl The bug was introduced in: facebook/rocksdb#2850 Fixed in: facebook/rocksdb#2881 update-submodule: rocksdb Reviewed By: lloyd Differential Revision: D5834658 (18889a6) fbshipit-source-id: 22625fd3ff2
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Aug 16, 2021
Summary: Bump rocksdb to include the fix for rocksdb.trx_info_rpl The bug was introduced in: facebook/rocksdb#2850 Fixed in: facebook/rocksdb#2881 update-submodule: rocksdb Reviewed By: lloyd Differential Revision: D5834658 (facebook@18889a6) fbshipit-source-id: 22625fd3ff2
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Aug 17, 2021
Summary: Bump rocksdb to include the fix for rocksdb.trx_info_rpl The bug was introduced in: facebook/rocksdb#2850 Fixed in: facebook/rocksdb#2881 update-submodule: rocksdb Reviewed By: lloyd Differential Revision: D5834658 (facebook@18889a6) fbshipit-source-id: 22625fd3ff2
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Aug 30, 2021
Summary: Bump rocksdb to include the fix for rocksdb.trx_info_rpl The bug was introduced in: facebook/rocksdb#2850 Fixed in: facebook/rocksdb#2881 update-submodule: rocksdb Reviewed By: lloyd Differential Revision: D5834658 (facebook@18889a6) fbshipit-source-id: 22625fd3ff2
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Aug 30, 2021
Summary: Bump rocksdb to include the fix for rocksdb.trx_info_rpl The bug was introduced in: facebook/rocksdb#2850 Fixed in: facebook/rocksdb#2881 update-submodule: rocksdb Reviewed By: lloyd Differential Revision: D5834658 (facebook@18889a6) fbshipit-source-id: 22625fd3ff2
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Aug 31, 2021
Summary: Bump rocksdb to include the fix for rocksdb.trx_info_rpl The bug was introduced in: facebook/rocksdb#2850 Fixed in: facebook/rocksdb#2881 update-submodule: rocksdb Reviewed By: lloyd Differential Revision: D5834658 (facebook@18889a6) fbshipit-source-id: 22625fd3ff2
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Sep 1, 2021
Summary: Bump rocksdb to include the fix for rocksdb.trx_info_rpl The bug was introduced in: facebook/rocksdb#2850 Fixed in: facebook/rocksdb#2881 update-submodule: rocksdb Reviewed By: lloyd Differential Revision: D5834658 (facebook@18889a6) fbshipit-source-id: 22625fd3ff2
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Sep 2, 2021
Summary: Bump rocksdb to include the fix for rocksdb.trx_info_rpl The bug was introduced in: facebook/rocksdb#2850 Fixed in: facebook/rocksdb#2881 update-submodule: rocksdb Reviewed By: lloyd Differential Revision: D5834658 (facebook@18889a6) fbshipit-source-id: 22625fd3ff2
hermanlee
pushed a commit
to facebook/mysql-5.6
that referenced
this pull request
Jan 10, 2022
Summary: Bump rocksdb to include the fix for rocksdb.trx_info_rpl The bug was introduced in: facebook/rocksdb#2850 Fixed in: facebook/rocksdb#2881 @update-submodule: rocksdb Reviewed By: lloyd Differential Revision: D5834658
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jan 17, 2022
Summary: Bump rocksdb to include the fix for rocksdb.trx_info_rpl The bug was introduced in: facebook/rocksdb#2850 Fixed in: facebook/rocksdb#2881 @update-submodule: rocksdb Reviewed By: lloyd Differential Revision: D5834658
ldonoso
pushed a commit
to ldonoso/percona-server
that referenced
this pull request
Mar 15, 2022
Summary: Bump rocksdb to include the fix for rocksdb.trx_info_rpl The bug was introduced in: facebook/rocksdb#2850 Fixed in: facebook/rocksdb#2881 @update-submodule: rocksdb Reviewed By: lloyd Differential Revision: D5834658
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 20, 2022
Summary: Bump rocksdb to include the fix for rocksdb.trx_info_rpl The bug was introduced in: facebook/rocksdb#2850 Fixed in: facebook/rocksdb#2881 @update-submodule: rocksdb Reviewed By: lloyd Differential Revision: D5834658
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 23, 2022
Summary: Bump rocksdb to include the fix for rocksdb.trx_info_rpl The bug was introduced in: facebook/rocksdb#2850 Fixed in: facebook/rocksdb#2881 @update-submodule: rocksdb Reviewed By: lloyd Differential Revision: D5834658
laurynas-biveinis
pushed a commit
to laurynas-biveinis/mysql-5.6
that referenced
this pull request
Aug 11, 2022
Summary: Bump rocksdb to include the fix for rocksdb.trx_info_rpl The bug was introduced in: facebook/rocksdb#2850 Fixed in: facebook/rocksdb#2881 @update-submodule: rocksdb Reviewed By: lloyd Differential Revision: D5834658
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Mar 25, 2023
Summary: Bump rocksdb to include the fix for rocksdb.trx_info_rpl The bug was introduced in: facebook/rocksdb#2850 Fixed in: facebook/rocksdb#2881 @update-submodule: rocksdb Reviewed By: lloyd Differential Revision: D5834658
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Mar 28, 2023
Summary: Bump rocksdb to include the fix for rocksdb.trx_info_rpl The bug was introduced in: facebook/rocksdb#2850 Fixed in: facebook/rocksdb#2881 @update-submodule: rocksdb Reviewed By: lloyd Differential Revision: D5834658
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jun 1, 2023
Summary: Bump rocksdb to include the fix for rocksdb.trx_info_rpl The bug was introduced in: facebook/rocksdb#2850 Fixed in: facebook/rocksdb#2881 @update-submodule: rocksdb Reviewed By: lloyd Differential Revision: D5834658
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jun 14, 2023
Summary: Bump rocksdb to include the fix for rocksdb.trx_info_rpl The bug was introduced in: facebook/rocksdb#2850 Fixed in: facebook/rocksdb#2881 @update-submodule: rocksdb Reviewed By: lloyd Differential Revision: D5834658
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Apr 9, 2024
Summary: Bump rocksdb to include the fix for rocksdb.trx_info_rpl The bug was introduced in: facebook/rocksdb#2850 Fixed in: facebook/rocksdb#2881 @update-submodule: rocksdb Reviewed By: lloyd Differential Revision: D5834658
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
#2850 disallow calling
WriteBatchWithIndex::GetFromBatchAndDB()withStackableDB, which break MyRocks usage. The fix is simply static castdb->GetRootDB()toDBImplto access internal API. This is safe becauseReadCallbackis only used insideTransactionDBand the pointer it provide is aDBImpl.Test Plan:
Under rocksdb repo
Under myrocks repo