-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove unused code #3055
remove unused code #3055
Conversation
db/db_impl.cc
Outdated
@@ -576,8 +576,6 @@ Status DBImpl::SetDBOptions( | |||
immutable_db_options_); | |||
env_options_for_compaction_.bytes_per_sync |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think this is also pointless as it's available in BuildDBOptions...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ajkr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ajkr is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
fixup 6a541af. This code didn't do anything because (1)
bytes_per_sync
is assigned inEnvOptions
's constructor; and (2)OptimizeForCompactionTableWrite
's return value was ignored, even though its only purpose is to return something.Test Plan:
make check -j64