Make trash-to-DB size ratio limit configurable #3158
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Allow users to configure the trash-to-DB size ratio limit, so that ratelimits for deletes can be enforced even when larger portions of the database are being deleted. Test Plan: Reviewers: tec Subscribers: kolmike, logdevice-diffs@ Tasks: T22635202 Tags: logdevice Blame Revision:
There was a problem hiding this comment.
@gdavidsson has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@gdavidsson has updated the pull request. View: changes, changes since last import |
There was a problem hiding this comment.
@gdavidsson has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
util/delete_scheduler.h
Outdated
| assert(r >= 0); | ||
| max_trash_db_ratio_ = r; | ||
| return max_trash_db_ratio_.store(r); |
There was a problem hiding this comment.
I think return here is confusing
|
@gdavidsson has updated the pull request. View: changes, changes since last import |
There was a problem hiding this comment.
@gdavidsson has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Allow users to configure the trash-to-DB size ratio limit, so
that ratelimits for deletes can be enforced even when larger portions of
the database are being deleted.