New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose all remaining read and write options via the C API #3185
Expose all remaining read and write options via the C API #3185
Conversation
Thanks @glittershark. Can you expose all the options that are missing from the C API? It is better to do them all in one shot rather than having a separate PR for each. |
Happy to! |
Expose almost all remaining read and write options via the C API. The only thing that's not here is table_filter, as it's not clear how to allow C callers to pass `std::function`s.
74d9f1b
to
a689d37
Compare
@glittershark has updated the pull request. |
@maysamyabandeh Updated to expose all options except |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maysamyabandeh has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sagar0 is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sagar0 is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sagar0 is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Expose read and write options via the C API