Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "No need for Restart Interval for meta blocks" #3188

Closed
wants to merge 1 commit into from

Conversation

miasantreble
Copy link
Contributor

@miasantreble miasantreble commented Nov 20, 2017

See issue 3169 for more information

This reverts commit 593d3de.

Current plan:

  1. cherry pick this commit to 5.9 release
  2. work on a new fix that doesn't break cockroachdb

See issue 3169 for more information

This reverts commit 593d3de.
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@miasantreble has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@miasantreble is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@miasantreble miasantreble deleted the revert-PR-2940 branch November 21, 2017 00:42
ajkr pushed a commit that referenced this pull request Nov 21, 2017
Summary:
See [issue 3169](#3169) for more information

This reverts commit 593d3de.
Closes #3188

Differential Revision: D6379271

Pulled By: miasantreble

fbshipit-source-id: 88f9ed67ba52237ad9b6f7251db83672b62d7537
@zhangjinpeng87
Copy link
Contributor

Any problem with restart interval is kMaxInt32? @miasantreble

@miasantreble
Copy link
Contributor Author

@zhangjinpeng1987 maybe not, will work on a new fix and do more testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants