WritePrepared Txn: GC old_commit_map_ #3247
Conversation
There was a problem hiding this comment.
@maysamyabandeh has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
| // Thread-safety is provided with old_commit_map_mutex_. | ||
| std::map<uint64_t, uint64_t> old_commit_map_; | ||
| std::map<SequenceNumber, std::set<SequenceNumber>> old_commit_map_; |
There was a problem hiding this comment.
Replace set with sorted array/vector? Presumably binary search on vector is faster than searching on sets.
|
@maysamyabandeh has updated the pull request. View: changes, changes since last import |
There was a problem hiding this comment.
@maysamyabandeh has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
| bool need_gc = false; | ||
| { | ||
| ReadLock rl(&old_commit_map_mutex_); | ||
| auto prep_set_entry = old_commit_map_.find(snap_seq); |
There was a problem hiding this comment.
Shall we do a binary search? (edit: never mind, I misread it)
|
@maysamyabandeh has updated the pull request. View: changes, changes since last import |
There was a problem hiding this comment.
@maysamyabandeh has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@maysamyabandeh has updated the pull request. View: changes, changes since last import |
There was a problem hiding this comment.
@maysamyabandeh has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@maysamyabandeh has updated the pull request. View: changes, changes since last import |
There was a problem hiding this comment.
@maysamyabandeh has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Garbage collect entries from old_commit_map_ when the corresponding snapshots are released.