Add possibility to change ttl on open DB #3292
Conversation
Change ttl in TtlCompactionFilterFactory on open db. Next time a filter is created, it will filter accroding to the set ttl.
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
maysamyabandeh
requested review from
miasantreble
and removed request for
miasantreble
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
@falkevik thanks for contributing to RocksDB. |
utilities/ttl/db_ttl_impl.cc
Outdated
| std::shared_ptr<TtlCompactionFilterFactory> filter; | ||
| Options opts; | ||
| opts = GetOptions(h); | ||
| filter = std::static_pointer_cast<TtlCompactionFilterFactory>(opts.compaction_filter_factory); |
There was a problem hiding this comment.
line too long, please limit width to 80 characters.
|
ok, will add a test. |
There was a problem hiding this comment.
@miasantreble has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@falkevik has updated the pull request. View: changes, changes since last import |
There was a problem hiding this comment.
@miasantreble has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
LGTM, there is currently a failure in AutomaticConflictsWithManualCompaction which is being fixed right now. Once master is green, I will rebase and merge this PR. Thanks @falkevik
|
@falkevik has updated the pull request. View: changes, changes since last import |
There was a problem hiding this comment.
@miasantreble has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
@miasantreble is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Summary: We have seen cases where it could be good to change TTL on already open DB. Change ttl in TtlCompactionFilterFactory on open db. Next time a filter is created, it will filter accroding to the set TTL. Is this something that could be useful for others? Any downsides? Closes facebook#3292 Differential Revision: D6731993 Pulled By: miasantreble fbshipit-source-id: 73b94d69237b11e8730734389052429d621a6b1e
We have seen cases where it could be good to change TTL on already open DB.
Change ttl in TtlCompactionFilterFactory on open db.
Next time a filter is created, it will filter accroding to the set TTL.
Is this something that could be useful for others?
Any downsides?