Use default fs in DestroyDB #3324
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you mean there is a data race between two threads? If the file is gone, then why GetChildren() returns it? |
maysamyabandeh
force-pushed
the
del-relax
branch
from
617e4d4
to
5d76dec
Compare
|
@maysamyabandeh has updated the pull request. |
|
@siying The original description was incorrect. I corrected that and also applied the patch that you suggested offline. |
There was a problem hiding this comment.
@maysamyabandeh has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
siying
approved these changes
Jan 4, 2018
maysamyabandeh
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seems to be a bug in btrfs that the makes readdir return recently unlink-ed files. This problem showed up in transaction_test when we call DestroyDB right after deleting the DB. Closing the DB deleted all the absolute files but one of them still showed up in the GetChildren call inside DestroyDB, which resulted in "file does not exist" error when it tried to attempt it.
FaultInjectionTestEnv::DeleteFile asserts on DeleteFile return status. By using the default fs for DestroyDB we simply ignore errors resulted from attempting to delete such files in DestroyDB.