fix DBTest.AutomaticConflictsWithManualCompaction #3375
Conversation
ajkr
force-pushed
the
fix-auto-manual-cmp-test2
branch
from
7d5fbf5
to
0166eda
Compare
|
@ajkr has updated the pull request. |
There was a problem hiding this comment.
@ajkr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@ajkr has updated the pull request. View: changes, changes since last import |
|
This uncovered another test failure: |
There was a problem hiding this comment.
@ajkr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@ajkr Thanks much! I didn't realize "exclusive manual compaction can only conflict with automatic compactions scheduled after it". |
|
landing as it passed on phabricator |
There was a problem hiding this comment.
@ajkr is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Summary: After af92d4a, only exclusive manual compaction can have conflict. dc360df updated the conflict-checking test case accordingly. But we missed the point that exclusive manual compaction can only conflict with automatic compactions scheduled after it, since it waits on pending automatic compactions before it begins running. This PR updates the test case to ensure the automatic compactions are scheduled after the manual compaction starts but before it finishes, thus ensuring a conflict. I also cleaned up the test case to use less space as I saw it cause out-of-space error on travis. Closes facebook#3375 Differential Revision: D6735162 Pulled By: ajkr fbshipit-source-id: 020530a4e150a4786792dce7cec5d66b420cb884
After af92d4a, only exclusive manual compaction can have conflict. dc360df updated the conflict-checking test case accordingly. But we missed the point that exclusive manual compaction can only conflict with automatic compactions scheduled after it, since it waits on pending automatic compactions before it begins running.
This PR updates the test case to ensure the automatic compactions are scheduled after the manual compaction starts but before it finishes, thus ensuring a conflict. I also cleaned up the test case to use less space as I saw it cause out-of-space error on travis.
Test Plan:
make check -j64