Blob DB: dump blob_db_options.min_blob_size #3400
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
@yiwu-arbug has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
sagar0
approved these changes
Jan 23, 2018
There was a problem hiding this comment.
@yiwu-arbug is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
yiwu-arbug
pushed a commit
that referenced
this pull request
Feb 1, 2018
Summary: min_blob_size was missing from BlobDBOptions::Dump. Closes #3400 Differential Revision: D6781525 Pulled By: yiwu-arbug fbshipit-source-id: 40d9b391578d7f8c91bd89f4ce2eda5064864c25
amytai
pushed a commit
to amytai/rocksdb
that referenced
this pull request
Mar 9, 2018
Summary: min_blob_size was missing from BlobDBOptions::Dump. Closes facebook#3400 Differential Revision: D6781525 Pulled By: yiwu-arbug fbshipit-source-id: 40d9b391578d7f8c91bd89f4ce2eda5064864c25
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
min_blob_size was missing from BlobDBOptions::Dump.
Test Plan:
Run db_bench with --use_blob_db --blob_db_min_blob_size=42. Sample output:
https://gist.github.com/yiwu-arbug/3d10894100c8c3757e9a070de29ee974