-
Notifications
You must be signed in to change notification settings - Fork 6.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Abstract merge operator in Java + Thread JNI attachment automatic management + loader management for static variables #3432
Open
publicocean0
wants to merge
14
commits into
facebook:main
Choose a base branch
from
publicocean0:abstractMergeOperator
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 12 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
5ea5bc0
fix std::unique_ptr<char[]>
publicocean0 c2e588f
first attempt to merge transactions api
publicocean0 dde032a
include transaction_db
publicocean0 8f1e628
fix transactions
publicocean0 6e73f37
associative /not asociative merge operator + automatic detaching thre…
publicocean0 6e0c351
associative /not asociative merge operator + automatic detaching thre…
publicocean0 093450e
remove debug folder in commit
publicocean0 ea6c238
fix: adding RocksdbException in the java signature
publicocean0 8fe4788
fix signature in AbstractNotAssociativeMergeOperator
publicocean0 b36b334
fix jni_vm_unload: it is not called, changed strategy. Improved abstr…
publicocean0 b63a0e4
remove std::cout
publicocean0 1cecf71
splitted pull request with java transactions from this pull request.S…
publicocean0 4e14bc7
Fix compilation problems
adamretter 4cb8946
Start of fixing code
adamretter File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -27,7 +27,7 @@ make_config.mk | |
CMakeCache.txt | ||
CMakeFiles/ | ||
build/ | ||
|
||
cmake-build-debug/ | ||
ldb | ||
manifest_dump | ||
sst_dump | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -930,7 +930,7 @@ if(WITH_TESTS) | |
table/mock_table.cc | ||
util/fault_injection_test_env.cc | ||
utilities/cassandra/test_utils.cc | ||
) | ||
java/rocksjni/init.h java/rocksjni/init.cc) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sort |
||
# test utilities are only build in debug | ||
enable_testing() | ||
add_custom_target(check COMMAND ${CMAKE_CTEST_COMMAND}) | ||
|
242 changes: 242 additions & 0 deletions
242
cmake-build-debug/third-party/gtest-1.7.0/fused-src/gtest/Makefile
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,242 @@ | ||
# CMAKE generated file: DO NOT EDIT! | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Remove this entire directory, it's generated |
||
# Generated by "Unix Makefiles" Generator, CMake Version 3.9 | ||
|
||
# Default target executed when no arguments are given to make. | ||
default_target: all | ||
|
||
.PHONY : default_target | ||
|
||
# Allow only one "make -f Makefile2" at a time, but pass parallelism. | ||
.NOTPARALLEL: | ||
|
||
|
||
#============================================================================= | ||
# Special targets provided by cmake. | ||
|
||
# Disable implicit rules so canonical targets will work. | ||
.SUFFIXES: | ||
|
||
|
||
# Remove some rules from gmake that .SUFFIXES does not remove. | ||
SUFFIXES = | ||
|
||
.SUFFIXES: .hpux_make_needs_suffix_list | ||
|
||
|
||
# Suppress display of executed commands. | ||
$(VERBOSE).SILENT: | ||
|
||
|
||
# A target that is always out of date. | ||
cmake_force: | ||
|
||
.PHONY : cmake_force | ||
|
||
#============================================================================= | ||
# Set environment variables for the build. | ||
|
||
# The shell in which to execute make rules. | ||
SHELL = /bin/sh | ||
|
||
# The CMake executable. | ||
CMAKE_COMMAND = /home/cristian/Scaricati/clion-2017.3.1/bin/cmake/bin/cmake | ||
|
||
# The command to remove a file. | ||
RM = /home/cristian/Scaricati/clion-2017.3.1/bin/cmake/bin/cmake -E remove -f | ||
|
||
# Escaping for special characters. | ||
EQUALS = = | ||
|
||
# The top-level source directory on which CMake was run. | ||
CMAKE_SOURCE_DIR = /data/git/rocksdb | ||
|
||
# The top-level build directory on which CMake was run. | ||
CMAKE_BINARY_DIR = /data/git/rocksdb/cmake-build-debug | ||
|
||
#============================================================================= | ||
# Targets provided globally by CMake. | ||
|
||
# Special rule for the target install/strip | ||
install/strip: preinstall | ||
@$(CMAKE_COMMAND) -E cmake_echo_color --switch=$(COLOR) --cyan "Installing the project stripped..." | ||
/home/cristian/Scaricati/clion-2017.3.1/bin/cmake/bin/cmake -DCMAKE_INSTALL_DO_STRIP=1 -P cmake_install.cmake | ||
.PHONY : install/strip | ||
|
||
# Special rule for the target install/strip | ||
install/strip/fast: preinstall/fast | ||
@$(CMAKE_COMMAND) -E cmake_echo_color --switch=$(COLOR) --cyan "Installing the project stripped..." | ||
/home/cristian/Scaricati/clion-2017.3.1/bin/cmake/bin/cmake -DCMAKE_INSTALL_DO_STRIP=1 -P cmake_install.cmake | ||
.PHONY : install/strip/fast | ||
|
||
# Special rule for the target install/local | ||
install/local: preinstall | ||
@$(CMAKE_COMMAND) -E cmake_echo_color --switch=$(COLOR) --cyan "Installing only the local directory..." | ||
/home/cristian/Scaricati/clion-2017.3.1/bin/cmake/bin/cmake -DCMAKE_INSTALL_LOCAL_ONLY=1 -P cmake_install.cmake | ||
.PHONY : install/local | ||
|
||
# Special rule for the target install/local | ||
install/local/fast: preinstall/fast | ||
@$(CMAKE_COMMAND) -E cmake_echo_color --switch=$(COLOR) --cyan "Installing only the local directory..." | ||
/home/cristian/Scaricati/clion-2017.3.1/bin/cmake/bin/cmake -DCMAKE_INSTALL_LOCAL_ONLY=1 -P cmake_install.cmake | ||
.PHONY : install/local/fast | ||
|
||
# Special rule for the target install | ||
install: preinstall | ||
@$(CMAKE_COMMAND) -E cmake_echo_color --switch=$(COLOR) --cyan "Install the project..." | ||
/home/cristian/Scaricati/clion-2017.3.1/bin/cmake/bin/cmake -P cmake_install.cmake | ||
.PHONY : install | ||
|
||
# Special rule for the target install | ||
install/fast: preinstall/fast | ||
@$(CMAKE_COMMAND) -E cmake_echo_color --switch=$(COLOR) --cyan "Install the project..." | ||
/home/cristian/Scaricati/clion-2017.3.1/bin/cmake/bin/cmake -P cmake_install.cmake | ||
.PHONY : install/fast | ||
|
||
# Special rule for the target list_install_components | ||
list_install_components: | ||
@$(CMAKE_COMMAND) -E cmake_echo_color --switch=$(COLOR) --cyan "Available install components are: \"devel\" \"runtime\"" | ||
.PHONY : list_install_components | ||
|
||
# Special rule for the target list_install_components | ||
list_install_components/fast: list_install_components | ||
|
||
.PHONY : list_install_components/fast | ||
|
||
# Special rule for the target edit_cache | ||
edit_cache: | ||
@$(CMAKE_COMMAND) -E cmake_echo_color --switch=$(COLOR) --cyan "No interactive CMake dialog available..." | ||
/home/cristian/Scaricati/clion-2017.3.1/bin/cmake/bin/cmake -E echo No\ interactive\ CMake\ dialog\ available. | ||
.PHONY : edit_cache | ||
|
||
# Special rule for the target edit_cache | ||
edit_cache/fast: edit_cache | ||
|
||
.PHONY : edit_cache/fast | ||
|
||
# Special rule for the target test | ||
test: | ||
@$(CMAKE_COMMAND) -E cmake_echo_color --switch=$(COLOR) --cyan "Running tests..." | ||
/home/cristian/Scaricati/clion-2017.3.1/bin/cmake/bin/ctest --force-new-ctest-process $(ARGS) | ||
.PHONY : test | ||
|
||
# Special rule for the target test | ||
test/fast: test | ||
|
||
.PHONY : test/fast | ||
|
||
# Special rule for the target rebuild_cache | ||
rebuild_cache: | ||
@$(CMAKE_COMMAND) -E cmake_echo_color --switch=$(COLOR) --cyan "Running CMake to regenerate build system..." | ||
/home/cristian/Scaricati/clion-2017.3.1/bin/cmake/bin/cmake -H$(CMAKE_SOURCE_DIR) -B$(CMAKE_BINARY_DIR) | ||
.PHONY : rebuild_cache | ||
|
||
# Special rule for the target rebuild_cache | ||
rebuild_cache/fast: rebuild_cache | ||
|
||
.PHONY : rebuild_cache/fast | ||
|
||
# The main all target | ||
all: cmake_check_build_system | ||
cd /data/git/rocksdb/cmake-build-debug && $(CMAKE_COMMAND) -E cmake_progress_start /data/git/rocksdb/cmake-build-debug/CMakeFiles /data/git/rocksdb/cmake-build-debug/third-party/gtest-1.7.0/fused-src/gtest/CMakeFiles/progress.marks | ||
cd /data/git/rocksdb/cmake-build-debug && $(MAKE) -f CMakeFiles/Makefile2 third-party/gtest-1.7.0/fused-src/gtest/all | ||
$(CMAKE_COMMAND) -E cmake_progress_start /data/git/rocksdb/cmake-build-debug/CMakeFiles 0 | ||
.PHONY : all | ||
|
||
# The main clean target | ||
clean: | ||
cd /data/git/rocksdb/cmake-build-debug && $(MAKE) -f CMakeFiles/Makefile2 third-party/gtest-1.7.0/fused-src/gtest/clean | ||
.PHONY : clean | ||
|
||
# The main clean target | ||
clean/fast: clean | ||
|
||
.PHONY : clean/fast | ||
|
||
# Prepare targets for installation. | ||
preinstall: all | ||
cd /data/git/rocksdb/cmake-build-debug && $(MAKE) -f CMakeFiles/Makefile2 third-party/gtest-1.7.0/fused-src/gtest/preinstall | ||
.PHONY : preinstall | ||
|
||
# Prepare targets for installation. | ||
preinstall/fast: | ||
cd /data/git/rocksdb/cmake-build-debug && $(MAKE) -f CMakeFiles/Makefile2 third-party/gtest-1.7.0/fused-src/gtest/preinstall | ||
.PHONY : preinstall/fast | ||
|
||
# clear depends | ||
depend: | ||
cd /data/git/rocksdb/cmake-build-debug && $(CMAKE_COMMAND) -H$(CMAKE_SOURCE_DIR) -B$(CMAKE_BINARY_DIR) --check-build-system CMakeFiles/Makefile.cmake 1 | ||
.PHONY : depend | ||
|
||
# Convenience name for target. | ||
third-party/gtest-1.7.0/fused-src/gtest/CMakeFiles/gtest.dir/rule: | ||
cd /data/git/rocksdb/cmake-build-debug && $(MAKE) -f CMakeFiles/Makefile2 third-party/gtest-1.7.0/fused-src/gtest/CMakeFiles/gtest.dir/rule | ||
.PHONY : third-party/gtest-1.7.0/fused-src/gtest/CMakeFiles/gtest.dir/rule | ||
|
||
# Convenience name for target. | ||
gtest: third-party/gtest-1.7.0/fused-src/gtest/CMakeFiles/gtest.dir/rule | ||
|
||
.PHONY : gtest | ||
|
||
# fast build rule for target. | ||
gtest/fast: | ||
cd /data/git/rocksdb/cmake-build-debug && $(MAKE) -f third-party/gtest-1.7.0/fused-src/gtest/CMakeFiles/gtest.dir/build.make third-party/gtest-1.7.0/fused-src/gtest/CMakeFiles/gtest.dir/build | ||
.PHONY : gtest/fast | ||
|
||
gtest-all.o: gtest-all.cc.o | ||
|
||
.PHONY : gtest-all.o | ||
|
||
# target to build an object file | ||
gtest-all.cc.o: | ||
cd /data/git/rocksdb/cmake-build-debug && $(MAKE) -f third-party/gtest-1.7.0/fused-src/gtest/CMakeFiles/gtest.dir/build.make third-party/gtest-1.7.0/fused-src/gtest/CMakeFiles/gtest.dir/gtest-all.cc.o | ||
.PHONY : gtest-all.cc.o | ||
|
||
gtest-all.i: gtest-all.cc.i | ||
|
||
.PHONY : gtest-all.i | ||
|
||
# target to preprocess a source file | ||
gtest-all.cc.i: | ||
cd /data/git/rocksdb/cmake-build-debug && $(MAKE) -f third-party/gtest-1.7.0/fused-src/gtest/CMakeFiles/gtest.dir/build.make third-party/gtest-1.7.0/fused-src/gtest/CMakeFiles/gtest.dir/gtest-all.cc.i | ||
.PHONY : gtest-all.cc.i | ||
|
||
gtest-all.s: gtest-all.cc.s | ||
|
||
.PHONY : gtest-all.s | ||
|
||
# target to generate assembly for a file | ||
gtest-all.cc.s: | ||
cd /data/git/rocksdb/cmake-build-debug && $(MAKE) -f third-party/gtest-1.7.0/fused-src/gtest/CMakeFiles/gtest.dir/build.make third-party/gtest-1.7.0/fused-src/gtest/CMakeFiles/gtest.dir/gtest-all.cc.s | ||
.PHONY : gtest-all.cc.s | ||
|
||
# Help Target | ||
help: | ||
@echo "The following are some of the valid targets for this Makefile:" | ||
@echo "... all (the default if no target is provided)" | ||
@echo "... clean" | ||
@echo "... depend" | ||
@echo "... install/strip" | ||
@echo "... install/local" | ||
@echo "... install" | ||
@echo "... list_install_components" | ||
@echo "... edit_cache" | ||
@echo "... test" | ||
@echo "... rebuild_cache" | ||
@echo "... gtest" | ||
@echo "... gtest-all.o" | ||
@echo "... gtest-all.i" | ||
@echo "... gtest-all.s" | ||
.PHONY : help | ||
|
||
|
||
|
||
#============================================================================= | ||
# Special targets to cleanup operation of make. | ||
|
||
# Special rule to run CMake to check the build system integrity. | ||
# No rule that depends on this can have commands that come from listfiles | ||
# because they might be regenerated. | ||
cmake_check_build_system: | ||
cd /data/git/rocksdb/cmake-build-debug && $(CMAKE_COMMAND) -H$(CMAKE_SOURCE_DIR) -B$(CMAKE_BINARY_DIR) --check-build-system CMakeFiles/Makefile.cmake 0 | ||
.PHONY : cmake_check_build_system | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needed? Looks like it got included anyway.