Compilation fixes for powerpc build, -Wparentheses-equality error and missing header guards #3462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without the guards, a compilation with -D__STDC_FORMAT_MACROS errors out with tools/write_stress.cc:59:0: error: "__STDC_FORMAT_MACROS" redefined [-Werror] #define __STDC_FORMAT_MACROS
Fix the following error:
rocksdb/monitoring/instrumented_mutex.cc:20:114: error: equality comparison with extraneous parentheses [-Werror,-Wparentheses-equality]
PerfStepTimer perf_step_timer_db_mutex_lock_nanos(&(perf_context.db_mutex_lock_nanos), true); if ((stats_code_ == DB_MUTEX_WAIT_MICROS)) { perf_step_timer_db_mutex_lock_nanos.Start(); };
Fixes the following error: rocksdb/util/crc32c.cc:44:12: error: 'rocksdb::crc32c::arch_ppc_crc32' defined but not used [-Werror=unused-variable] static int arch_ppc_crc32 = 0;
There was a problem hiding this comment.
@siying has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
@sagar0 is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request contains miscellaneous compilation fixes.
Thanks,
Chinmay