[codemod] comment unused parameters to turn on -Wunused-parameter flag #3662
Conversation
There was a problem hiding this comment.
@Dayvedde has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@Dayvedde has updated the pull request. View: changes, changes since last import |
|
@Dayvedde has updated the pull request. View: changes, changes since last import |
There was a problem hiding this comment.
@Dayvedde has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Dayvedde
force-pushed
the
enable-wunused-parameter
branch
from
45ffdaf
to
e6dfb3d
Compare
|
@Dayvedde has updated the pull request. |
Dayvedde
force-pushed
the
enable-wunused-parameter
branch
from
e6dfb3d
to
c18b562
Compare
|
@Dayvedde has updated the pull request. |
There was a problem hiding this comment.
@Dayvedde has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
@ajkr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Dayvedde
force-pushed
the
enable-wunused-parameter
branch
from
c18b562
to
9cb7a74
Compare
|
@Dayvedde has updated the pull request. |
There was a problem hiding this comment.
@Dayvedde has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Dayvedde
force-pushed
the
enable-wunused-parameter
branch
from
9cb7a74
to
f39edc2
Compare
|
@Dayvedde has updated the pull request. |
Dayvedde
force-pushed
the
enable-wunused-parameter
branch
from
f39edc2
to
c25c4ce
Compare
|
@Dayvedde has updated the pull request. |
|
@Dayvedde has updated the pull request. View: changes, changes since last import |
|
@Dayvedde has updated the pull request. View: changes, changes since last import |
|
@Dayvedde has updated the pull request. View: changes, changes since last import |
|
@Dayvedde has updated the pull request. View: changes, changes since last import |
|
@Dayvedde has updated the pull request. View: changes, changes since last import |
|
@Dayvedde has updated the pull request. View: changes, changes since last import |
|
@Dayvedde has updated the pull request. View: changes, changes since last import |
|
@Dayvedde has updated the pull request. View: changes, changes since last import |
|
commit ac7b1fb now builds successfully on FreeBSD |
|
@Dayvedde has updated the pull request. View: changes, changes since last import |
|
@Dayvedde has updated the pull request. View: changes, changes since last import |
|
Slowly but surely fixing all these errors... |
|
@Dayvedde has updated the pull request. View: changes, changes since last import |
|
Hi @miasantreble, I have fixed all of the errors! |
There was a problem hiding this comment.
@Dayvedde has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
@Dayvedde is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Summary: this PR fixes a few failed contbuild: 1. ASAN memory leak in Block::NewIterator (table/block.cc:429). the proper destruction of first_level_iter_ and second_level_iter_ of two_level_iterator.cc is missing from the code after the refactoring in #3406 2. various unused param errors introduced by #3662 3. updated comment for `ForceReleaseCachedEntry` to emphasize the use of `force_erase` flag. Closes #3718 Reviewed By: maysamyabandeh Differential Revision: D7621192 Pulled By: miasantreble fbshipit-source-id: 476c94264083a0730ded957c29de7807e4f5b146
Summary: this PR fixes a few failed contbuild: 1. ASAN memory leak in Block::NewIterator (table/block.cc:429). the proper destruction of first_level_iter_ and second_level_iter_ of two_level_iterator.cc is missing from the code after the refactoring in #3406 2. various unused param errors introduced by #3662 3. updated comment for `ForceReleaseCachedEntry` to emphasize the use of `force_erase` flag. Closes #3718 Reviewed By: maysamyabandeh Differential Revision: D7621192 Pulled By: miasantreble fbshipit-source-id: 476c94264083a0730ded957c29de7807e4f5b146
Summary: this PR fixes a few failed contbuild: 1. ASAN memory leak in Block::NewIterator (table/block.cc:429). the proper destruction of first_level_iter_ and second_level_iter_ of two_level_iterator.cc is missing from the code after the refactoring in #3406 2. various unused param errors introduced by #3662 3. updated comment for `ForceReleaseCachedEntry` to emphasize the use of `force_erase` flag. Closes #3718 Reviewed By: maysamyabandeh Differential Revision: D7621192 Pulled By: miasantreble fbshipit-source-id: 476c94264083a0730ded957c29de7807e4f5b146
Summary: this PR fixes a few failed contbuild: 1. ASAN memory leak in Block::NewIterator (table/block.cc:429). the proper destruction of first_level_iter_ and second_level_iter_ of two_level_iterator.cc is missing from the code after the refactoring in #3406 2. various unused param errors introduced by #3662 3. updated comment for `ForceReleaseCachedEntry` to emphasize the use of `force_erase` flag. Closes #3718 Reviewed By: maysamyabandeh Differential Revision: D7621192 Pulled By: miasantreble fbshipit-source-id: 476c94264083a0730ded957c29de7807e4f5b146
This PR comments out the rest of the unused arguments which allow us to turn on the -Wunused-parameter flag. This is the second part of a codemod relating to #3557.
Test Plan: