cmake: add options for enabling TBB and NUMA support #3750
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
see also facebook#3036 Signed-off-by: Kefu Chai <tchaikov@gmail.com>
chfast
approved these changes
Apr 20, 2018
|
can we leave it enabled by default in case anyone's relying on the default behavior? |
|
@ajkr we could, but enabling it by default would break the build for anyone who don't have numctl and libtbb development package installed. but i understand, the breakage is more visible than a rocksdb silently built w/o numa and tbb support. i will enable it if you think it's okay. |
siying
approved these changes
Apr 25, 2018
|
I wasn't sure - but since Siying thinks it's ok, it should be fine |
There was a problem hiding this comment.
@ajkr is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see also #3036
Signed-off-by: Kefu Chai tchaikov@gmail.com