-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow options file in db_stress and db_crashtest #3768
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ajkr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
ToString(FLAGS_level0_slowdown_writes_trigger + 2), | ||
ToString(FLAGS_level0_slowdown_writes_trigger + 4), | ||
ToString(options_.level0_slowdown_writes_trigger), | ||
ToString(options_.level0_slowdown_writes_trigger + 2), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this doesn't behave well when people set max_int in their options file :/.
FLAGS_options_file.c_str(), s.ToString().c_str()); | ||
exit(1); | ||
} | ||
options_ = Options(db_options, cf_descriptors[0].options); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
breaks rocksdb lite
@ajkr has updated the pull request. View: changes, changes since last import |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ajkr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ajkr is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
BuildOptionsTable
afterOpen
so it can useoptions_
once it has been populated either from flags or from filedb_crashtest.py
Test Plan: