Extend format 3 to partitioned index/filters #3958
Conversation
|
In one sample it reduces the top-level index size from 10348 to 7491 bytes (28% saving). |
|
@maysamyabandeh has updated the pull request. View: changes |
There was a problem hiding this comment.
@maysamyabandeh has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@maysamyabandeh has updated the pull request. View: changes, changes since last import |
… cf) might have been already deleted
|
@maysamyabandeh has updated the pull request. View: changes, changes since last import |
There was a problem hiding this comment.
@maysamyabandeh has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
The failed travis test is unrelated: |
db/db_test_util.cc
Outdated
| // Format 3 changes the binary index format. Since partitioned index is a | ||
| // super-set of simple indexes, we are also using kTwoLevelIndexSearch to | ||
| // test this format. | ||
| table_options.format_version = 3; | ||
| table_options.index_type = BlockBasedTableOptions::kTwoLevelIndexSearch; | ||
| options.prefix_extractor.reset(NewNoopTransform()); |
There was a problem hiding this comment.
Sorry I missed it previously but why do we want to set prefix extractor?
There was a problem hiding this comment.
I had copy-pasted it from kBlockBasedTableWithPartitionedIndex. Removing it.
|
@maysamyabandeh has updated the pull request. View: changes, changes since last import |
There was a problem hiding this comment.
@maysamyabandeh is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
@maysamyabandeh is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Summary: format_version 3 changes the format of index blocks by storing user keys instead of the internal keys, which saves 8-bytes per key. This patch extends the format to top-level indexes in partitioned index/filters. Closes #3958 Differential Revision: D8294615 Pulled By: maysamyabandeh fbshipit-source-id: 17666cc16b8076c363972e2308e31547e835f0fe
Summary: format_version 3 changes the format of index blocks by storing user keys instead of the internal keys, which saves 8-bytes per key. This patch extends the format to top-level indexes in partitioned index/filters. Closes facebook#3958 Differential Revision: D8294615 Pulled By: maysamyabandeh fbshipit-source-id: 17666cc16b8076c363972e2308e31547e835f0fe
format_version 3 changes the format of index blocks by storing user keys instead of the internal keys, which saves 8-bytes per key. This patch extends the format to top-level indexes in partitioned index/filters.