Udpate db_universal_compaction_test according to PR #3970 #3995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: The SST file sizes changed slightly after the improvement of PR facebook#3970 which reduces the size of the properties block. Before PR facebook#3970 a size ratio compaction included all of the first four flushed files but it only includes two files after. We increase the size_ratio universal compaction option to make that compaction include all four files again. Test Plan: 1. make check -j64 2. ./build_tools/rocksdb-lego-determinator run_no_compression
sagar0
approved these changes
Jun 14, 2018
There was a problem hiding this comment.
@fgwu has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
@fgwu is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
rcane
pushed a commit
to rcane/rocksdb
that referenced
this pull request
Sep 13, 2018
…cebook#3995) Summary: The SST file sizes changed slightly after the improvement of PR facebook#3970 which reduces the size of the properties block. Before PR facebook#3970 a size ratio compaction included all of the first four flushed files but it only includes two files after. We increase the size_ratio universal compaction option to make that compaction include all four files again. Closes facebook#3995 Differential Revision: D8426925 Pulled By: fgwu fbshipit-source-id: 1429c38672e9f4fb4d4881fd4b06db45c4861d62
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The SST file sizes changed slightly after the improvement of PR #3970
which reduces the size of the properties block. Before PR #3970 a size
ratio compaction included all of the first four flushed files but it
only includes two files after. We increase the size_ratio universal
compaction option to make that compaction include all four files again.
Test Plan:
make check -j64./build_tools/rocksdb-lego-determinator run_no_compression