Add path to WritableFileWriter. #4039
Conversation
Test plan: ``` $ make clean && make -j16 all check ```
There was a problem hiding this comment.
@riversand963 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@riversand963 has updated the pull request. Re-import the pull request |
…963/rocksdb into add_path_to_writablefilewriter
There was a problem hiding this comment.
@riversand963 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@riversand963 has updated the pull request. Re-import the pull request |
There was a problem hiding this comment.
@riversand963 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours has expired. Before we can review or merge your code, we need you to email cla@fb.com with your details so we can update your status. |
|
@riversand963 has updated the pull request. Re-import the pull request |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
1 similar comment
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
There was a problem hiding this comment.
riversand963 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
What is it for? Can we include the motivation for this change in the description? |
|
@riversand963 has updated the pull request. Re-import the pull request |
There was a problem hiding this comment.
riversand963 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
| @@ -37,7 +37,7 @@ namespace rocksdb { | |||
| namespace { | |||
| static const int kMaxArgCount = 100; | |||
| static const size_t kArgBufferSize = 100000; | |||
| } | |||
| } // namespace | |||
There was a problem hiding this comment.
did the linter add this? cool
There was a problem hiding this comment.
I don't remember -__-b
Thanks for your suggestion of git add -p
|
@riversand963 has updated the pull request. Re-import the pull request |
There was a problem hiding this comment.
riversand963 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
Thanks @ajkr for reviewing. |
Summary: We want to sample the file I/O issued by RocksDB and report the function calls. This requires us to include the file paths otherwise it's hard to tell what has been going on. Pull Request resolved: facebook#4039 Differential Revision: D8670178 Pulled By: riversand963 fbshipit-source-id: 97ee806d1c583a2983e28e213ee764dc6ac28f7a
We want to sample the file I/O issued by RocksDB and report the function calls. This requires us to include the file paths otherwise it's hard to tell what has been going on.
Test plan: