In delete scheduler, before ftruncate file for slow delete, check whether there is other hard links #4093
Conversation
There was a problem hiding this comment.
@siying has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
util/delete_scheduler.cc
Outdated
| ROCKS_LOG_INFO(info_log_, | ||
| "Cannot delete %s slowly through ftruncate from trash " | ||
| "as it has other links", | ||
| path_in_trash.c_str()); | ||
| } | ||
| } |
There was a problem hiding this comment.
should we also log something if it's unsupported? Maybe windows users expect files to be gradually truncated but we silently don't do it because NumFileLinks is unsupported.
|
@siying has updated the pull request. Re-import the pull request |
There was a problem hiding this comment.
@siying has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
…ther there is other hard links Summary: Right now slow deletion with ftruncate doesn't work well with checkpoints because it ruin hard linked files in checkpoints. To fix it, check the file has no other hard link before ftruncate it. Test Plan: Add a unit test Address comment
siying
force-pushed
the
slow_rm_hardlink_supportr
branch
from
508349e
to
96d1ab2
Compare
|
@siying has updated the pull request. Re-import the pull request |
There was a problem hiding this comment.
@siying has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@siying has updated the pull request. Re-import the pull request |
|
I can't imagine how the Windows failure is related to this diff. I'm landing it. |
There was a problem hiding this comment.
@siying is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
…ther there is other hard links (facebook#4093) Summary: Right now slow deletion with ftruncate doesn't work well with checkpoints because it ruin hard linked files in checkpoints. To fix it, check the file has no other hard link before ftruncate it. Pull Request resolved: facebook#4093 Differential Revision: D8730360 Pulled By: siying fbshipit-source-id: 756eea5bce8a87b9a2ea3a5bfa190b2cab6f75df
Summary: Right now slow deletion with ftruncate doesn't work well with checkpoints because it ruin hard linked files in checkpoints. To fix it, check the file has no other hard link before ftruncate it.
Test Plan: Add a unit test