Build improvements: Split docker targets and parallelize java builds #4165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sagar0
changed the title
sagar0
changed the title
sagar0
approved these changes
Jul 23, 2018
There was a problem hiding this comment.
@sagar0 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
Note: I updated the title as we are striving towards having good git-log messages going forward. Feel free to update further. |
|
@sagar0 sounds good - are there any guidelines on naming/structuring titles? |
|
@adamretter No special guidelines yet; we will update the doc. We are trying to make sure that there's a good title / summary before the final acceptance of a PR, as these are the ones that appear in git log. |
rcane
pushed a commit
to rcane/rocksdb
that referenced
this pull request
Sep 13, 2018
Summary: Pull Request resolved: facebook#4165 Differential Revision: D8955531 Pulled By: sagar0 fbshipit-source-id: 97d5a1375e200bde3c6414f94703504a4ed7536a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.