Improve FullFilterBitsReader::HashMayMatch's doc #4202
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It should be change to this: Do you have time to apply this change? And also piggyback the minor fixes mentioned in these PRs? |
yaojingguo
force-pushed
the
HashMayMatch-comment
branch
from
6fb5ead
to
8bba425
Compare
|
@maysamyabandeh A new commit which includes the suggested PRs is submitted. Please take a look. |
util/bloom.cc
Outdated
| // FilterBitsBuilder::Finish. This method must return true if the key was | ||
| // passed to FilterBitsBuilder::AddKey. This method may return true or false | ||
| // if the key was not on the list, but it should aim to return false with a | ||
| // high probability. |
There was a problem hiding this comment.
Can you remove the trailing spaces?
maysamyabandeh
changed the title
- Remove the unused variable write_context. - Fix two typos. - Improve HashMayMatch function's comment.
yaojingguo
force-pushed
the
HashMayMatch-comment
branch
from
8bba425
to
8d6bbf2
Compare
There was a problem hiding this comment.
maysamyabandeh is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
rcane
pushed a commit
to rcane/rocksdb
that referenced
this pull request
Sep 13, 2018
Summary: HashMayMatch is related to AddKey() instead of CreateFilter(). Also applies some minor Fixes facebook#4191 facebook#4200 facebook#3910 Pull Request resolved: facebook#4202 Differential Revision: D9180945 Pulled By: maysamyabandeh fbshipit-source-id: 6f07b81c5bb9bda5c0273475b486ba8a030471e6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HashMayMatch is related to AddKey() instead of CreateFilter().
Also applies some minor Fixes #4191 #4200 #3910