Add the unit test of Iterator to trace_analyzer_test #4282
Conversation
tools/trace_analyzer_test.cc
Outdated
| "-analyze_merge", | ||
| "-analyze_single_delete", | ||
| "-analyze_range_delete", | ||
| "-analyze_iterator", |
There was a problem hiding this comment.
For the iterator test you don't need to analyze other operations like get/put/delete/etc, right?
There was a problem hiding this comment.
Yeah. I will remove the other unrelated analyzing options
tools/trace_analyzer_test.cc
Outdated
| Status s = env_->FileExists(trace_path); | ||
| if (!s.ok()) { | ||
| GenerateTrace(trace_path); | ||
| } |
There was a problem hiding this comment.
Since the initial setup steps are the same for most of the other tests, you can pull the common code into one function, and I guess you can pass in the needed params to it.
zhichao-cao
force-pushed
the
analyzer_iter_test
branch
from
f936c23
to
c552838
Compare
There was a problem hiding this comment.
zhichao-cao has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@zhichao-cao has updated the pull request. Re-import the pull request |
There was a problem hiding this comment.
zhichao-cao has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Summary: Add the unit test of Iterator (Seek and SeekForPrev) to trace_analyzer_test. The output files after analyzing the trace file are checked to make sure that analyzing results are correct. Pull Request resolved: facebook#4282 Differential Revision: D9436758 Pulled By: zhichao-cao fbshipit-source-id: 88d471c9a69e07382d9c6a45eba72773b171e7c2
Add the unit test of Iterator (Seek and SeekForPrev) to trace_analyzer_test. The output files after analyzing the trace file are checked to make sure that analyzing results are correct.
Test Plan:
make asan_check