Revert "Digest ZSTD compression dictionary once per SST file (#4251)" #4347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
ajkr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
anand1976
approved these changes
Sep 5, 2018
|
Yes, the first calls to |
|
|
There was a problem hiding this comment.
ajkr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
ajkr is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
rcane
pushed a commit
to rcane/rocksdb
that referenced
this pull request
Sep 13, 2018
…k#4251)" (facebook#4347) Summary: Reverting is needed to unblock a user building against master, who is blocked for multiple days due to a thread-safety issue in `GetEmptyDict`. We haven't been able to fix it quickly, so reverting. Simply ran `git revert 6c40806`. There were no merge conflicts. Pull Request resolved: facebook#4347 Differential Revision: D9668365 Pulled By: ajkr fbshipit-source-id: 0c56334f0a23cf5ee0233d4e4679eae6709739cd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverting is needed to unblock a user building against master, who is blocked for multiple days due to a thread-safety issue in
GetEmptyDict. We haven't been able to fix it quickly, so reverting.Simply ran
git revert 6c40806e51a89386d2b066fddf73d3fd03a36f65. There were no merge conflicts.Test Plan:
make check -j64