Reduce IndexBlockIter size #4358
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
maysamyabandeh has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
Unit test failure seems to be related. |
siying
approved these changes
Sep 12, 2018
anand1976
reviewed
Sep 12, 2018
table/block.h
Outdated
| @@ -468,10 +468,10 @@ class IndexBlockIter final : public BlockIter<BlockHandle> { | |||
| BlockPrefixIndex* prefix_index, bool key_includes_seq, | |||
| bool value_is_full, bool block_contents_pinned, | |||
| DataBlockHashIndex* /*data_block_hash_index*/) { | |||
| InitializeBase(comparator, data, restarts, num_restarts, | |||
| kDisableGlobalSequenceNumber, block_contents_pinned); | |||
| InitializeBase(key_includes_seq_ ? comparator : user_comparator, data, | |||
There was a problem hiding this comment.
key_includes_seq_ has not been initialized yet.
There was a problem hiding this comment.
maysamyabandeh has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
anand1976
pushed a commit
that referenced
this pull request
Sep 12, 2018
Summary: With #3983 the size of IndexBlockIter was increased. This had resulted in a regression on P50 latencies in one of our benchmarks. The patch reduces IndexBlockIter size be eliminating active_comparator_ field from the class. Pull Request resolved: #4358 Differential Revision: D9781737 Pulled By: maysamyabandeh fbshipit-source-id: 71e2b28d90ff0813db9e04b737ae73e185583c52
rcane
pushed a commit
to rcane/rocksdb
that referenced
this pull request
Sep 13, 2018
Summary: With facebook#3983 the size of IndexBlockIter was increased. This had resulted in a regression on P50 latencies in one of our benchmarks. The patch reduces IndexBlockIter size be eliminating active_comparator_ field from the class. Pull Request resolved: facebook#4358 Differential Revision: D9781737 Pulled By: maysamyabandeh fbshipit-source-id: 71e2b28d90ff0813db9e04b737ae73e185583c52
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #3983 the size of IndexBlockIter was increased. This had resulted in a regression on P50 latencies in one of our benchmarks. The patch reduces IndexBlockIter size be eliminating active_comparator_ field from the class.