-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove sync point from Block destructor #4370
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sagar0 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
ajkr
approved these changes
Sep 15, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
sagar0
added a commit
that referenced
this pull request
Sep 17, 2018
Summary: AddressSanitizer: heap-use-after-free in std::__atomic_base<bool>::load(std::memory_order) const ==1798517==ABORTING ``` Pull Request resolved: #4370 Differential Revision: D9844146 Pulled By: sagar0 fbshipit-source-id: 18a2970b1d504b4f6c8fb04857f26e0f32124dd1
cngzhnp
pushed a commit
to cngzhnp/rocksdb
that referenced
this pull request
Sep 18, 2018
Summary: This is a follow up to facebook#4370. The earlier comment is not correct. Thanks to ajkr for pointing this out. Pull Request resolved: facebook#4380 Differential Revision: D9874667 Pulled By: sagar0 fbshipit-source-id: f4e092d86b29c715258210b770643d367e38caae
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A sync point was introduced in Block destructor in f3d91a0, to test that iterators release all data blocks at the end of their lifetime.
However, a user who initializes a static ColumnFamilyOptions saw use-after-free issue with SyncPoint Data.
Since we don't have a good enough solution to solve all cases, I am inclining towards just removing
TEST_SYNC_POINT("Block::~Block");
from ~Block() destructor, and disable IteratorPinnedMemory test. This will temporarily move RocksDB to the previous state of not having a unit test for checking that all data blocks are released by iterators. We should spend more time thinking of the right way to fix the static order initialization, but that will take much longer warranting more discussion.Call Stack:
Test Plan: