FindFile: use std::lower_bound reduce the repeated code. #4372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JiYou
changed the title
JiYou
changed the title
JiYou
force-pushed
the
find.file
branch
3 times, most recently
from
76a2063
to
351ae11
Compare
Summary: `FindFile()` and `FindFileInRange()` actually works as the same of `std::lower_bound()`. Use `std::lower_bound()` to reduce the repeated code. - change `FindFile()` and `FindFileInRange()` to `std::lower_bound()` Signed-off-by: JiYou <jiyou09@gmail.com>
|
looks like somebody was practicing for an interview when writing the old code. |
There was a problem hiding this comment.
ajkr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
FindFile()andFindFileInRange()actually works as the sameof
std::lower_bound(). Usestd::lower_bound()to reduce therepeated code.
FindFile()andFindFileInRange()to usestd::lower_bound()Signed-off-by: JiYou jiyou09@gmail.com